Bug 193252

Summary:

Move ResourceLoadStatistics files from UIProcess to NetworkProcess

Product:

WebKit

Reporter:

Brent Fulgham <bfulgham>

Component:

WebKit2

Assignee:

Brent Fulgham <bfulgham>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, bfulgham, commit-queue, ews-watchlist, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

193199

Attachments:

Description	Flags
Patch	none
Patch for landing	none
Patch for landing	none

Description Brent Fulgham 2019-01-08 13:02:42 PST

This patch is the first part of a refactoring to move the ResourceLoadStatistics logic from the UIProcess to the NetworkProcess.

This patch moves code into different folders and adjusts necessary build files, but does not change where the code executes.

A few files were modified to add include files that were needed after these moves, due to vagaries of the unified build system.

Comment 1 Radar WebKit Bug Importer 2019-01-08 13:04:31 PST

<rdar://problem/47125401>

Comment 2 Brent Fulgham 2019-01-08 13:11:27 PST

Created attachment 358627 [details]
Patch

Comment 3 EWS Watchlist 2019-01-08 13:15:13 PST

Attachment 358627 [details] did not pass style-queue:


ERROR: Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:219:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:444:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:521:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:567:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:579:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:620:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.cpp:414:  An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Total errors found: 7 in 25 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 4 Brent Fulgham 2019-01-08 13:25:32 PST

Created attachment 358629 [details]
Patch for landing

Comment 5 EWS Watchlist 2019-01-08 13:30:40 PST

Attachment 358629 [details] did not pass style-queue:


ERROR: Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:219:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:444:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:521:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:567:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:579:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:620:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.cpp:411:  An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Total errors found: 7 in 25 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 6 Brent Fulgham 2019-01-08 13:35:49 PST

Created attachment 358632 [details]
Patch for landing

Comment 7 EWS Watchlist 2019-01-08 13:38:09 PST

Attachment 358632 [details] did not pass style-queue:


ERROR: Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:219:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:444:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:521:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:567:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:579:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:620:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.cpp:411:  An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Total errors found: 7 in 26 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 8 WebKit Commit Bot 2019-01-08 14:02:26 PST

Comment on attachment 358632 [details]
Patch for landing

Clearing flags on attachment: 358632

Committed r239747: <https://trac.webkit.org/changeset/239747>

Comment 9 WebKit Commit Bot 2019-01-08 14:02:27 PST

All reviewed patches have been landed.  Closing bug.