Bug 193207

Summary: Remove use of NetworkProcess::singleton for downloads
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch beidson: review+

Alex Christensen
Reported 2019-01-07 13:45:14 PST
Remove use of NetworkProcess::singleton for downloads
Attachments
Patch (13.23 KB, patch)
2019-01-07 13:45 PST, Alex Christensen 		beidson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2019-01-07 13:45:54 PST
Created attachment 358524 [details] Patch
Brady Eidson
Comment 2 2019-01-07 14:24:37 PST
Comment on attachment 358524 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358524&action=review > Source/WebKit/NetworkProcess/Downloads/PendingDownload.h:51 > + PendingDownload(IPC::Connection*, NetworkLoadParameters&&, DownloadID, NetworkSession&, const String& suggestedName); > + PendingDownload(IPC::Connection*, std::unique_ptr<NetworkLoad>&&, ResponseCompletionHandler&&, DownloadID, const WebCore::ResourceRequest&, const WebCore::ResourceResponse&); Sure wish we could make these take Connection&
Alex Christensen
Comment 3 2019-01-07 14:29:37 PST
Wouldn't it be great? http://trac.webkit.org/r239699
Radar WebKit Bug Importer
Comment 4 2019-01-07 14:30:30 PST
<rdar://problem/47096626>
Note You need to log in before you can comment on or make changes to this bug.