Bug 193175

Summary: API test broken: TestWebKitAPI.WebKit.CustomDataStorePathsVersusCompletionHandlers
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ap, beidson, cdumez, commit-queue, lforschler, ryanhaddad, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=193152
Attachments:
Description Flags
Patch none

Aakash Jain
Reported 2019-01-06 06:15:57 PST
This API test seems to be broken recently TestWebKitAPI.WebKit.CustomDataStorePathsVersusCompletionHandlers API test in https://ews-build.webkit-uat.org/#/builders/19/builds/60 started failing, while it was passing earlier. This API-test build was triggered by https://ews-build.webkit-uat.org/#/builders/25/builds/745 at which time ToT was at 4817fbafca3 Service Worker fetch should obey its referrer policy https://bugs.webkit.org/show_bug.cgi?id=193152 Seems like https://bugs.webkit.org/show_bug.cgi?id=193152 (r239659) might have broken this API test.
Attachments
Patch (10.70 KB, patch)
2019-01-06 11:19 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2019-01-06 06:17:44 PST
build.webkit.org also points to the same commit r239659. Failing build: https://build.webkit.org/builders/Apple%20High%20Sierra%20Debug%20WK2%20%28Tests%29/builds/6101 Passing build: https://build.webkit.org/builders/Apple%20High%20Sierra%20Debug%20WK2%20%28Tests%29/builds/6100 Build 6101 built commit r239659, and this API test started failing.
youenn fablet
Comment 2 2019-01-06 11:03:18 PST
This API test is indeed broken since: - It copies the SW database to the previous path (-3.sqlite3 instead of -4.sqlite3) - It uses a SW database with the previous schema
youenn fablet
Comment 3 2019-01-06 11:19:01 PST
Created attachment 358464 [details] Patch
WebKit Commit Bot
Comment 4 2019-01-07 09:06:33 PST
Comment on attachment 358464 [details] Patch Clearing flags on attachment: 358464 Committed r239676: <https://trac.webkit.org/changeset/239676>
WebKit Commit Bot
Comment 5 2019-01-07 09:06:35 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-01-07 09:14:36 PST
<rdar://problem/47086545>
Note You need to log in before you can comment on or make changes to this bug.