Bug 193171

Summary:

Implement the css-color-4 behavior for inheritance of currentColor

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

CSS

Assignee:

Joonghun Park <jh718.park>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dino, dstockwell, emilio, esprehn+autocc, ews-watchlist, fmalita, glenn, graouts, gyuyoung.kim, jh718.park, joepeck, koivisto, kondapallykalyan, macpherson, me, menard, miriam, pdr, sabouhallawa, schenney, sergio, simon.fraser, webkit-bug-importer

Priority:

Keywords:

BrowserCompat, InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=158782
https://bugs.webkit.org/show_bug.cgi?id=210005
https://bugs.webkit.org/show_bug.cgi?id=210017

Attachments:

Description	Flags
Testcase	none
wip	none
wip	none
wip	none
wip	none
patch	simon.fraser: review+
patch	none
patch	none
patch	none

Simon Fraser (smfr)

Reported 2019-01-05 11:50:16 PST

According to https://drafts.csswg.org/css-color/#resolving-color-values, currentColor should inherit as the keyword, not the resolved color.

Attachments
Testcase (537 bytes, text/html) 2019-01-05 11:56 PST, Simon Fraser (smfr)	no flags	Details
wip (11.11 KB, patch) 2020-04-03 05:54 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
wip (11.09 KB, patch) 2020-04-03 06:04 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
wip (30.84 KB, patch) 2020-04-03 09:58 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
wip (60.83 KB, patch) 2020-04-03 10:27 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (71.13 KB, patch) 2020-04-04 00:52 PDT, Antti Koivisto	simon.fraser: review+	Details Formatted Diff Diff
patch (72.67 KB, patch) 2020-04-04 09:49 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (72.68 KB, patch) 2020-04-04 10:04 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (72.68 KB, patch) 2020-04-04 10:05 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.

Simon Fraser (smfr)

Comment 1 2019-01-05 11:56:37 PST

Created attachment 358440 [details] Testcase

Simon Fraser (smfr)

Comment 2 2019-01-05 12:07:23 PST

It looks like StyleColor was added for this, but it's not instantiated anywhere.

Radar WebKit Bug Importer

Comment 3 2019-01-15 10:18:28 PST

<rdar://problem/47287516>

Miriam Suzanne

Comment 4 2019-12-20 16:03:39 PST

This is a pretty frustrating bug in a number of common `currentColor` use-cases, not limited to: - Using `fill: currentColor` to get SVG fills in-sync with text colors - Changing link/button colors in different states, `currentColor` is a much more useful "reset" than something like `initial` - This is especially true with changing `text-decoration-color`

Antti Koivisto

Comment 5 2020-04-03 05:54:51 PDT

Created attachment 395368 [details] wip

Antti Koivisto

Comment 6 2020-04-03 06:04:50 PDT

Created attachment 395369 [details] wip

Antti Koivisto

Comment 7 2020-04-03 09:58:24 PDT

Created attachment 395385 [details] wip

Antti Koivisto

Comment 8 2020-04-03 10:27:50 PDT

Created attachment 395391 [details] wip

Antti Koivisto

Comment 9 2020-04-04 00:21:45 PDT

*** Bug 158782 has been marked as a duplicate of this bug. ***

Antti Koivisto

Comment 10 2020-04-04 00:52:01 PDT

Created attachment 395441 [details] patch

Emilio Cobos Álvarez (:emilio)

Comment 11 2020-04-04 06:38:36 PDT

Comment on attachment 395441 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=395441&action=review > Source/WebCore/style/StyleBuilderState.cpp:-317 > - return m_style.color(); Setting setHasExplicitlyInheritedProperties shouldn't be needed here anymore, right? currentColor() doesn't depend on m_style.

Emilio Cobos Álvarez (:emilio)

Comment 12 2020-04-04 06:39:23 PDT

Not that it matters that much though, better safe than sorry I guess...

Antti Koivisto

Comment 13 2020-04-04 07:09:37 PDT

Need to do some more checking to ensure there is nothing left that needs it. I'll try to remove it in a separate patch.

Simon Fraser (smfr)

Comment 14 2020-04-04 08:44:14 PDT

Comment on attachment 395441 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=395441&action=review > LayoutTests/fast/borders/border-color-inherit-expected.html:1 > +<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN"> Maybe just <!DOCTYPE html> (and in the test too). > Source/WebCore/rendering/style/RenderStyle.h:1735 > + static Color currentColor() { return { }; } Maybe change initialTextEmphasisColor() to return curentColor(). > Source/WebCore/style/StyleBuilderState.cpp:324 > + // FIXME: 'currentcolor' should be resolved at use time to make it inherit correctly. You should file a bug on the FIXME and reference it here. That seems fairly important to fix. > Source/WebCore/svg/SVGStopElement.cpp:97 > + if (!stopColor.isValid()) > + stopColor = style.color(); A little helper function like RenderStyle::resolveCurrentColor or something would make this much more understandable.

Antti Koivisto

Comment 15 2020-04-04 09:49:36 PDT

Created attachment 395451 [details] patch

Antti Koivisto

Comment 16 2020-04-04 10:04:11 PDT

Created attachment 395453 [details] patch

Antti Koivisto

Comment 17 2020-04-04 10:05:19 PDT

Created attachment 395454 [details] patch

EWS

Comment 18 2020-04-04 11:16:30 PDT

Committed r259532: <https://trac.webkit.org/changeset/259532> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395454 [details].

Note You need to log in before you can comment on or make changes to this bug.