Bug 193160

Summary:

Web Inspector: Use save sheet instead of dialog where possible

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	none

Joseph Pecoraro

Reported 2019-01-04 14:15:20 PST

Use save sheet instead of dialog where possible Steps to Reproduce: 1. Inspect this page 2. Show Network Tab 3. Reload the page 4. Dock inspector 5. Click "Export" in the toolbar => Shows Save Dialog, expected Sheet to drop down from Toolbar Notes: - We use a sheet for a windowed inspector but didn't for docked.

Attachments
[PATCH] Proposed Fix (3.83 KB, patch) 2019-01-04 14:16 PST, Joseph Pecoraro	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Joseph Pecoraro

Comment 1 2019-01-04 14:15:41 PST

<rdar://problem/37399759>

Joseph Pecoraro

Comment 2 2019-01-04 14:16:24 PST

Created attachment 358366 [details] [PATCH] Proposed Fix

Devin Rousso

Comment 3 2019-01-04 15:21:13 PST

Comment on attachment 358366 [details] [PATCH] Proposed Fix rs=me, nice fix :)

WebKit Commit Bot

Comment 4 2019-01-04 16:34:06 PST

Comment on attachment 358366 [details] [PATCH] Proposed Fix Clearing flags on attachment: 358366 Committed r239647: <https://trac.webkit.org/changeset/239647>

WebKit Commit Bot

Comment 5 2019-01-04 16:34:08 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.