Bug 193160

Summary:

Web Inspector: Use save sheet instead of dialog where possible

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	none

Description Joseph Pecoraro 2019-01-04 14:15:20 PST

Use save sheet instead of dialog where possible

Steps to Reproduce:
1. Inspect this page
2. Show Network Tab
3. Reload the page
4. Dock inspector
5. Click "Export" in the toolbar
  => Shows Save Dialog, expected Sheet to drop down from Toolbar

Notes:
- We use a sheet for a windowed inspector but didn't for docked.

Comment 1 Joseph Pecoraro 2019-01-04 14:15:41 PST

<rdar://problem/37399759>

Comment 2 Joseph Pecoraro 2019-01-04 14:16:24 PST

Created attachment 358366 [details]
[PATCH] Proposed Fix

Comment 3 Devin Rousso 2019-01-04 15:21:13 PST

Comment on attachment 358366 [details]
[PATCH] Proposed Fix

rs=me, nice fix :)

Comment 4 WebKit Commit Bot 2019-01-04 16:34:06 PST

Comment on attachment 358366 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 358366

Committed r239647: <https://trac.webkit.org/changeset/239647>

Comment 5 WebKit Commit Bot 2019-01-04 16:34:08 PST

All reviewed patches have been landed.  Closing bug.