Bug 193121 – Bring back presentingApplicationPID

• Component: WebKit2
• Status: RESOLVED FIXED

[Keith Rollin]

Bug 192961 removes presentingApplicationPID from NetworkProcessCreationParameters because it was (a) stored in some global state, the use of which is being minimized, and (b) it was largely unused. However, it was actually still being used in some useful logging in order to tie together child processes with their parent process. Re-introduce this value to NetworkProcessCreationParameters so that we can log it. But, this time, just use it locally instead of storing it in some global state for later retrieval.

Make a similar change to WebContentProcess for consistency purposes.

[Radar WebKit Bug Importer]

<rdar://problem/47031634>

[Keith Rollin]

Actually, it sounds like the plans are for a Network Process to possibly have different parents, not necessarily just the one that actually created it. Therefore, instead of establishing a parent PID just once at startup, pass it in on every resource load request.

[Keith Rollin]

Created attachment 358287 [details]
Patch

[Keith Rollin]

Created attachment 358292 [details]
Fix windows build.

[Keith Rollin]

Created attachment 358293 [details]
Oh, let's be generous ... fix *all* the builds.

[Alex Christensen]

Comment on attachment 358293 [details]
Oh, let's be generous ... fix *all* the builds.

View in context: https://bugs.webkit.org/attachment.cgi?id=358293&action=review

> Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp:271
> +    loadParameters.parentPID = getCurrentProcessID();

This would be the pid of the WebProcess.  Is this what you wanted?  presentingApplicationPID would be the pid of the UIProcess.

[Keith Rollin]

Oh, right.

[Keith Rollin]

Created attachment 358334 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 358334 [details]
Patch

Clearing flags on attachment: 358334

Committed r239622: <https://trac.webkit.org/changeset/239622>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.