Bug 193102

Summary:

[ews-build] Check patch relevance before applying the patch

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

Tools / Tests

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, commit-queue, ews-watchlist, kocsen_chung, lforschler, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch	none

Description Aakash Jain 2019-01-03 03:06:38 PST

We should run the CheckPatchRelevance step before applying the patch. CheckPatchRelevance is very quick, usually less than a second, While applying the patch seems to take about half a minute (since it involve cleaning up any previous change, updating to ToT and then applying the patch).

For queues like WebKitPy-Tests where very little percentage of patches are actually relevant, it is a waste of time to apply the patch and then discover that the patch doesn't needs to be processed in the first place. Therefore checking the patch relevance should be one of the very first step.

Comment 1 Aakash Jain 2019-01-03 03:12:16 PST

Created attachment 358248 [details]
Proposed patch

Comment 2 EWS Watchlist 2019-01-03 03:15:06 PST Comment hidden (obsolete)

Attachment 358248 [details] did not pass style-queue:


ERROR: Tools/BuildSlaveSupport/ews-build/factories.py:37:  [Factory.__init__] Undefined variable 'CheckPatchRelevance'  [pylint/E0602] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 WebKit Commit Bot 2019-01-04 10:00:10 PST

Comment on attachment 358248 [details]
Proposed patch

Clearing flags on attachment: 358248

Committed r239616: <https://trac.webkit.org/changeset/239616>

Comment 4 WebKit Commit Bot 2019-01-04 10:00:11 PST

All reviewed patches have been landed.  Closing bug.

Comment 5 Radar WebKit Bug Importer 2019-01-04 10:03:41 PST

<rdar://problem/47050389>