Bug 193102

Summary: [ews-build] Check patch relevance before applying the patch
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, commit-queue, ews-watchlist, kocsen_chung, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch none

Aakash Jain
Reported 2019-01-03 03:06:38 PST
We should run the CheckPatchRelevance step before applying the patch. CheckPatchRelevance is very quick, usually less than a second, While applying the patch seems to take about half a minute (since it involve cleaning up any previous change, updating to ToT and then applying the patch). For queues like WebKitPy-Tests where very little percentage of patches are actually relevant, it is a waste of time to apply the patch and then discover that the patch doesn't needs to be processed in the first place. Therefore checking the patch relevance should be one of the very first step.
Attachments
Proposed patch (3.08 KB, patch)
2019-01-03 03:12 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2019-01-03 03:12:16 PST
Created attachment 358248 [details] Proposed patch
EWS Watchlist
Comment 2 2019-01-03 03:15:06 PST Comment hidden (obsolete)
WebKit Commit Bot
Comment 3 2019-01-04 10:00:10 PST
Comment on attachment 358248 [details] Proposed patch Clearing flags on attachment: 358248 Committed r239616: <https://trac.webkit.org/changeset/239616>
WebKit Commit Bot
Comment 4 2019-01-04 10:00:11 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2019-01-04 10:03:41 PST
<rdar://problem/47050389>
Note You need to log in before you can comment on or make changes to this bug.