Bug 193090

Summary: IndexedDB: When deleting databases, some open databases might be missed
Product: WebKit Reporter: Sihui Liu <sihui_liu>
Component: New BugsAssignee: Sihui Liu <sihui_liu>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, beidson, commit-queue, ews-watchlist, jsbell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
Patch for landing none

Sihui Liu
Reported 2019-01-02 14:52:38 PST
Currently we only close databases which have open database connections before deleting file.
Attachments
patch (2.37 KB, patch)
2019-01-02 14:58 PST, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.55 KB, patch)
2019-01-14 15:40 PST, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sihui Liu
Comment 1 2019-01-02 14:58:59 PST
Created attachment 358210 [details] patch
Brady Eidson
Comment 2 2019-01-11 09:22:05 PST
Comment on attachment 358210 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=358210&action=review > Source/WebCore/ChangeLog:3 > + IndexedDB: files should be deleted after databases being opened are closed This was also unclear to me. Maybe "When deleting databases, some open databases might be missed" > Source/WebCore/ChangeLog:8 > + We should close all open databases instead of databases from open database connections, because database thread "We should close all databases with an open backing store instead of looking at which ones have an open database connection. This is because a database might be in the process of getting a backing store before its connection has been created"
Sihui Liu
Comment 3 2019-01-14 15:40:47 PST
Created attachment 359085 [details] Patch for landing
WebKit Commit Bot
Comment 4 2019-01-14 16:19:23 PST
Comment on attachment 359085 [details] Patch for landing Clearing flags on attachment: 359085 Committed r239960: <https://trac.webkit.org/changeset/239960>
WebKit Commit Bot
Comment 5 2019-01-14 16:19:24 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-01-14 16:20:35 PST
<rdar://problem/47269748>
Note You need to log in before you can comment on or make changes to this bug.