| Summary: | Fix resourcetimingbufferfull bubbles attribute | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | cvazac | ||||||||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | achristensen, cdumez, commit-queue, ews-watchlist, rniwa, webkit-bug-importer | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
cvazac
2019-01-02 12:39:59 PST
Created attachment 358195 [details]
Patch
Attachment 358195 [details] did not pass style-queue:
ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 358196 [details]
Patch
Per spec change [1], the `bubbles` attribute on `resourcetimingbufferfull` events should no longer be set to `true` [2]. [1] https://github.com/w3c/resource-timing/pull/168 [2] https://github.com/w3c/resource-timing/pull/168/files#diff-eacf331f0ffc35d4b482f1d15a887d3bL848 Comment on attachment 358196 [details] Patch Attachment 358196 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/10607657 New failing tests: http/wpt/resource-timing/rt-performance-extensions.worker.html http/wpt/resource-timing/rt-performance-extensions.html Created attachment 358200 [details]
Archive of layout-test-results from ews102 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 358196 [details] Patch Attachment 358196 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/10607696 New failing tests: http/wpt/resource-timing/rt-performance-extensions.worker.html http/wpt/resource-timing/rt-performance-extensions.html Created attachment 358201 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Created attachment 358203 [details]
Patch
Comment on attachment 358203 [details]
Patch
r=me
Comment on attachment 358203 [details] Patch Clearing flags on attachment: 358203 Committed r239579: <https://trac.webkit.org/changeset/239579> All reviewed patches have been landed. Closing bug. |