Bug 193064

Summary: Test group results page from notification should not failed even for completed build type build requests.
Product: WebKit Reporter: dewei_zhu
Component: New BugsAssignee: dewei_zhu
Status: RESOLVED FIXED    
Severity: Normal CC: dewei_zhu, rniwa
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch rniwa: review+

dewei_zhu
Reported 2018-12-31 23:27:25 PST
Test group results page from notification should not contain rows for build type build requests.
Attachments
Patch (8.25 KB, patch)
2019-01-01 00:11 PST, dewei_zhu 		rniwa: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
dewei_zhu
Comment 1 2019-01-01 00:11:37 PST
Created attachment 358168 [details] Patch
Ryosuke Niwa
Comment 2 2019-01-10 20:46:53 PST
Comment on attachment 358168 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358168&action=review > Websites/perf.webkit.org/ChangeLog:3 > + Test group results page from notification should not failed even for completed build type build requests. Should probably revise this to say "Test group results notification should not say a build request to build had failed even when it had successfully completed" > Websites/perf.webkit.org/tools/js/test-group-result-page.js:110 > + cellValue = 'failed'; Should be capitalized.
dewei_zhu
Comment 3 2019-01-18 15:28:12 PST
<rdar://problem/43518845>
dewei_zhu
Comment 4 2019-01-18 17:05:50 PST
Landed in r240182.
Note You need to log in before you can comment on or make changes to this bug.