Bug 193055

Summary: .ycm_extra_conf.py should handle XXXInlines.h
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cgarcia, don.olmstead, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch cgarcia: review+

Yusuke Suzuki
Reported 2018-12-29 02:27:20 PST
.ycm_extra_conf.py should handle XXXInlines.h
Attachments
Patch (3.03 KB, patch)
2018-12-29 02:30 PST, Yusuke Suzuki 		cgarcia: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2018-12-29 02:30:00 PST
Created attachment 358135 [details] Patch
Carlos Garcia Campos
Comment 2 2018-12-31 05:50:05 PST
Comment on attachment 358135 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358135&action=review > Tools/gtk/ycm_extra_conf.py:90 > + else: Does this work? this else: is not correctly indented. It can be removed, though, since previous line is a return.
Yusuke Suzuki
Comment 3 2018-12-31 07:30:40 PST
(In reply to Carlos Garcia Campos from comment #2) > Comment on attachment 358135 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=358135&action=review > > > Tools/gtk/ycm_extra_conf.py:90 > > + else: > > Does this work? this else: is not correctly indented. It can be removed, > though, since previous line is a return. This is `else` for `for`, but yeah, we can just `return None` here. Fixed.
Yusuke Suzuki
Comment 4 2018-12-31 07:31:21 PST
Committed r239567: <https://trac.webkit.org/changeset/239567>
Radar WebKit Bug Importer
Comment 5 2018-12-31 07:32:59 PST
<rdar://problem/46987867>
Note You need to log in before you can comment on or make changes to this bug.