Summary: | .ycm_extra_conf.py should handle XXXInlines.h | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||
Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, cgarcia, don.olmstead, mcatanzaro, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Yusuke Suzuki
2018-12-29 02:27:20 PST
Created attachment 358135 [details]
Patch
Comment on attachment 358135 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358135&action=review > Tools/gtk/ycm_extra_conf.py:90 > + else: Does this work? this else: is not correctly indented. It can be removed, though, since previous line is a return. (In reply to Carlos Garcia Campos from comment #2) > Comment on attachment 358135 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=358135&action=review > > > Tools/gtk/ycm_extra_conf.py:90 > > + else: > > Does this work? this else: is not correctly indented. It can be removed, > though, since previous line is a return. This is `else` for `for`, but yeah, we can just `return None` here. Fixed. Committed r239567: <https://trac.webkit.org/changeset/239567> |