Bug 193035

Summary: [JSC][Win][Clang] warning: implicit conversion from 'size_t' (aka 'unsigned long long') to 'int32_t' (aka 'int') changes value from 18446744073709551552 to -64 [-Wconstant-conversion]
Product: WebKit Reporter: Fujii Hironori <Hironori.Fujii>
Component: JavaScriptCoreAssignee: Fujii Hironori <Hironori.Fujii>
Status: RESOLVED FIXED    
Severity: Normal CC: don.olmstead, ews-watchlist, keith_miller, mark.lam, msaboff, ross.kirsling, saam, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 171618    
Attachments:
Description Flags
Patch none

Description Fujii Hironori 2018-12-25 22:47:44 PST
[JSC][Win][Clang] warning: implicit conversion from 'size_t' (aka 'unsigned long long') to 'int32_t' (aka 'int') changes value from 18446744073709551552 to -64 [-Wconstant-conversion]

clang-cl reports the following warnings for WinCairo port x64 builds:

> ..\..\Source\JavaScriptCore\dfg/DFGJITCompiler.cpp(390,29):  warning: implicit conversion from 'size_t' (aka 'unsigned long long') to 'int32_t' (aka 'int') changes value from 18446744073709551552 to -64 [-Wconstant-conversion]
> ..\..\Source\JavaScriptCore\dfg/DFGJITCompiler.cpp(466,29):  warning: implicit conversion from 'size_t' (aka 'unsigned long long') to 'int32_t' (aka 'int') changes value from 18446744073709551552 to -64 [-Wconstant-conversion]
> ..\..\Source\JavaScriptCore\dfg/DFGJITCompiler.cpp(486,33):  warning: implicit conversion from 'size_t' (aka 'unsigned long long') to 'int32_t' (aka 'int') changes value from 18446744073709551552 to -64 [-Wconstant-conversion]
> ..\..\Source\JavaScriptCore\jit/JIT.cpp(732,29):  warning: implicit conversion from 'size_t' (aka 'unsigned long long') to 'int32_t' (aka 'int') changes value from 18446744073709551552 to -64 [-Wconstant-conversion]
> ..\..\Source\JavaScriptCore\jit/JIT.cpp(749,33):  warning: implicit conversion from 'size_t' (aka 'unsigned long long') to 'int32_t' (aka 'int') changes value from 18446744073709551552 to -64 [-Wconstant-conversion]
> ..\..\Source\JavaScriptCore\jit/ThunkGenerators.cpp(93,43):  warning: implicit conversion from 'size_t' (aka 'unsigned long long') to 'int32_t' (aka 'int') changes value from 18446744073709551552 to -64 [-Wconstant-conversion]
Comment 1 Fujii Hironori 2018-12-25 22:55:12 PST
Created attachment 358075 [details]
Patch
Comment 2 Yusuke Suzuki 2018-12-25 23:39:19 PST
Comment on attachment 358075 [details]
Patch

r=me
Comment 3 Fujii Hironori 2018-12-25 23:53:38 PST
Comment on attachment 358075 [details]
Patch

Clearing flags on attachment: 358075

Committed r239552: <https://trac.webkit.org/changeset/239552>
Comment 4 Fujii Hironori 2018-12-25 23:53:41 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-12-25 23:54:23 PST
<rdar://problem/46946537>