| Summary: | REGRESSION(r?): Web Inspector: Popovers have inset shadows | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Nikita Vasilyev <nvasilyev> | ||||||||||
| Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | bburg, commit-queue, hi, inspector-bugzilla-changes, joepeck, mattbaker, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | All | ||||||||||||
| OS: | All | ||||||||||||
| Attachments: |
|
||||||||||||
Created attachment 362664 [details]
Patch
Created attachment 362665 [details]
[Image] Before Patch is applied
Created attachment 362666 [details]
[Image] After Patch is applied
Do you know why this broke? Comment on attachment 362664 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=362664&action=review > Source/WebInspectorUI/UserInterface/Views/Popover.css:36 > --popover-shadow-color: hsla(0, 0%, 0%, 0.5); Can we reduce the padding now that the popover feels a little larger than it was before? Each of the `padding` declarations below could drop a pixel or two. Comment on attachment 362664 [details]
Patch
The macOS system blue seems much larger. For an example of a popover right click the URL bar and select "Settings for this website...". That shadow seems much larger and clearer than this one.
> The macOS system blue
system *popover blur*
I’d really like to know what change caused the regression in the first place. I feel like this happened relatively recently. (In reply to Nikita Vasilyev from comment #5) > Do you know why this broke? (In reply to Matt Baker from comment #9) > I’d really like to know what change caused the regression in the first place. I feel like this happened relatively recently. From what I could find, this code has existed since before Web Inspector was added to open source. Comment on attachment 362664 [details] Patch (In reply to Joseph Pecoraro from comment #7) > The macOS system popover blur seems much larger. For an example of a popover right click the URL bar and select "Settings for this website...". That shadow seems much larger and clearer than this one. View in context: https://bugs.webkit.org/attachment.cgi?id=362664&action=review >> Source/WebInspectorUI/UserInterface/Views/Popover.css:36 >> --popover-shadow-color: hsla(0, 0%, 0%, 0.5); > > Can we reduce the padding now that the popover feels a little larger than it was before? Each of the `padding` declarations below could drop a pixel or two. If we want to make the popover match (or be closer to) the system blur, we'd actually need to increase the padding, as otherwise the blur will get cut off by the bounds of the <canvas> itself. Comment on attachment 362664 [details]
Patch
r=me
Comment on attachment 362664 [details] Patch Clearing flags on attachment: 362664 Committed r241981: <https://trac.webkit.org/changeset/241981> All reviewed patches have been landed. Closing bug. |
Created attachment 357905 [details] [Image] Bug This doesn't seem intentional.