Bug 192957

Summary: [iOS] Some layout tests are failing after r239441
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: HTML EditingAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, bdakin, commit-queue, ryanhaddad, simon.fraser, thorton, tsavell, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Wenson Hsieh
Reported 2018-12-20 14:46:43 PST
SSIA
Attachments
Patch (3.58 KB, patch)
2018-12-20 16:13 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2018-12-20 15:00:19 PST
It looks like these are the relevant tests: • fast/events/ios/click-event-while-editing-node.html • fast/forms/ios/focus-long-textarea.html (this one can just be rebaselined) • fast/forms/ios/zoom-after-input-tap-wide-input.html (this one can just be rebaselined too) • fast/events/ios/key-command-italic-dispatches-keydown.html
Wenson Hsieh
Comment 2 2018-12-20 15:40:17 PST
(In reply to Wenson Hsieh from comment #1) > It looks like these are the relevant tests: > > • fast/events/ios/click-event-while-editing-node.html This test is actually dependent on buggy behavior (scrolling to the touch location rather than the selection), which was fixed in r239441. This just needs to be tweaked slightly.
Wenson Hsieh
Comment 3 2018-12-20 16:01:26 PST
(In reply to Wenson Hsieh from comment #1) > It looks like these are the relevant tests: > … > • fast/events/ios/key-command-italic-dispatches-keydown.html It turns out that this test has the same result before and after my change.
Wenson Hsieh
Comment 4 2018-12-20 16:08:10 PST
<rdar://problem/46781759>
Wenson Hsieh
Comment 5 2018-12-20 16:13:49 PST
Created attachment 357894 [details] Patch
WebKit Commit Bot
Comment 6 2018-12-20 17:32:23 PST
Comment on attachment 357894 [details] Patch Clearing flags on attachment: 357894 Committed r239482: <https://trac.webkit.org/changeset/239482>
WebKit Commit Bot
Comment 7 2018-12-20 17:32:24 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.