Bug 192948

Summary: Use Optional::hasValue() instead of Optional::has_value()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Web Template FrameworkAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ddkilzer, ews-watchlist, ggaren, rniwa, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 192728    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2018-12-20 12:40:56 PST
Use Optional::hasValue() instead of Optional::has_value().
Attachments
Patch (36.26 KB, patch)
2018-12-20 13:12 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2018-12-20 13:12:01 PST
Created attachment 357854 [details] Patch
EWS Watchlist
Comment 2 2018-12-20 13:16:15 PST
Attachment 357854 [details] did not pass style-queue: ERROR: Source/WTF/wtf/Optional.h:675: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 3 2018-12-20 16:40:17 PST
Comment on attachment 357854 [details] Patch Clearing flags on attachment: 357854 Committed r239477: <https://trac.webkit.org/changeset/239477>
WebKit Commit Bot
Comment 4 2018-12-20 16:40:19 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2018-12-20 16:45:49 PST
<rdar://problem/46887797>
Note You need to log in before you can comment on or make changes to this bug.