Bug 192936

Summary: [iOS] Replace "node assistance" terminology in WebKit with "focused element"
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: WebKit2Assignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, enrica, ews-watchlist, megan_gardner, mitz, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Update a Copyright year none

Wenson Hsieh
Reported 2018-12-20 09:08:59 PST
We use "node assistance" terminology in many places in WebKit to mean "focused element", but this is strange and confusing to anyone new to this code (e.g. the StartAssistingNode/StopAssistingNode IPC messages). WebPage also has methods like "elementDidFocus" and "elementDidBlur" that currently take Node*, but should really take Element&.
Attachments
Patch (199.63 KB, patch)
2018-12-20 09:40 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Update a Copyright year (199.64 KB, patch)
2018-12-20 09:42 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2018-12-20 09:40:01 PST
Created attachment 357819 [details] Patch
Wenson Hsieh
Comment 2 2018-12-20 09:42:37 PST
Created attachment 357820 [details] Update a Copyright year
EWS Watchlist
Comment 3 2018-12-20 09:47:27 PST
Attachment 357820 [details] did not pass style-queue: ERROR: Source/WebKit/Shared/FocusedElementInformation.h:48: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 1 in 32 files If any of these errors are false positives, please file a bug against check-webkit-style.
Wenson Hsieh
Comment 4 2018-12-20 09:50:30 PST
(In reply to Build Bot from comment #3) > Attachment 357820 [details] did not pass style-queue: > > > ERROR: Source/WebKit/Shared/FocusedElementInformation.h:48: enum members > should use InterCaps with an initial capital letter or initial 'k' for > C-style enums. [readability/enum_casing] [4] > Total errors found: 1 in 32 files > > > If any of these errors are false positives, please file a bug against > check-webkit-style. I feel like there should be an exception to this rule for certain acronyms (in this case, URL). I think InputType::URL certainly reads more cleanly than InputType::UniformResourceLocator.
Tim Horton
Comment 5 2018-12-20 10:26:04 PST
(In reply to Wenson Hsieh from comment #4) > (In reply to Build Bot from comment #3) > > Attachment 357820 [details] did not pass style-queue: > > > > > > ERROR: Source/WebKit/Shared/FocusedElementInformation.h:48: enum members > > should use InterCaps with an initial capital letter or initial 'k' for > > C-style enums. [readability/enum_casing] [4] > > Total errors found: 1 in 32 files > > > > > > If any of these errors are false positives, please file a bug against > > check-webkit-style. > > I feel like there should be an exception to this rule for certain acronyms > (in this case, URL). I think InputType::URL certainly reads more cleanly > than InputType::UniformResourceLocator. Agreed, so ignore it.
Tim Horton
Comment 6 2018-12-20 10:27:11 PST
Comment on attachment 357820 [details] Update a Copyright year rs=me (but strongly agree with the name change)
WebKit Commit Bot
Comment 7 2018-12-20 10:42:53 PST
Comment on attachment 357820 [details] Update a Copyright year Clearing flags on attachment: 357820 Committed r239454: <https://trac.webkit.org/changeset/239454>
WebKit Commit Bot
Comment 8 2018-12-20 10:42:55 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2018-12-20 10:43:35 PST
<rdar://problem/46876214>
Note You need to log in before you can comment on or make changes to this bug.