Bug 192933

Summary: Use Optional::valueOr() instead of Optional::value_or()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Web Template FrameworkAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ddkilzer, ews-watchlist, ggaren, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 192728    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2018-12-20 08:50:22 PST
Use Optional::valueOr() instead of Optional::value_or().
Attachments
Patch (219.85 KB, patch)
2018-12-20 09:10 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (218.97 KB, patch)
2018-12-20 11:39 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2018-12-20 09:10:30 PST
Created attachment 357817 [details] Patch
EWS Watchlist
Comment 2 2018-12-20 09:13:55 PST
Attachment 357817 [details] did not pass style-queue: ERROR: Source/WTF/wtf/Optional.h:681: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 152 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 3 2018-12-20 11:39:04 PST
Created attachment 357839 [details] Patch
EWS Watchlist
Comment 4 2018-12-20 11:43:35 PST
Attachment 357839 [details] did not pass style-queue: ERROR: Source/WTF/wtf/Optional.h:681: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 151 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 5 2018-12-20 11:53:11 PST
Comment on attachment 357839 [details] Patch r=me
Chris Dumez
Comment 6 2018-12-20 12:23:27 PST
Comment on attachment 357839 [details] Patch Clearing flags on attachment: 357839 Committed r239461: <https://trac.webkit.org/changeset/239461>
Chris Dumez
Comment 7 2018-12-20 12:23:29 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2018-12-20 12:24:36 PST
<rdar://problem/46879483>
Note You need to log in before you can comment on or make changes to this bug.