Bug 192933 - Use Optional::valueOr() instead of Optional::value_or()
Summary: Use Optional::valueOr() instead of Optional::value_or()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on: 192728
Blocks:
  Show dependency tree / graph
 
Reported: 2018-12-20 08:50 PST by Chris Dumez
Modified: 2018-12-20 12:24 PST (History)
6 users (show)

See Also:

Attachments
Patch (219.85 KB, patch)
2018-12-20 09:10 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (218.97 KB, patch)
2018-12-20 11:39 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2018-12-20 08:50:22 PST 
Use Optional::valueOr() instead of Optional::value_or().
Comment 1 Chris Dumez 2018-12-20 09:10:30 PST 
Created attachment 357817 [details]
Patch
Comment 2 EWS Watchlist 2018-12-20 09:13:55 PST 
Attachment 357817 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/Optional.h:681:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 152 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Chris Dumez 2018-12-20 11:39:04 PST 
Created attachment 357839 [details]
Patch
Comment 4 EWS Watchlist 2018-12-20 11:43:35 PST 
Attachment 357839 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/Optional.h:681:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 151 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Geoffrey Garen 2018-12-20 11:53:11 PST 
Comment on attachment 357839 [details]
Patch

r=me
Comment 6 Chris Dumez 2018-12-20 12:23:27 PST 
Comment on attachment 357839 [details]
Patch

Clearing flags on attachment: 357839

Committed r239461: <https://trac.webkit.org/changeset/239461>
Comment 7 Chris Dumez 2018-12-20 12:23:29 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-12-20 12:24:36 PST 
<rdar://problem/46879483>