Summary: | Add dark mode styles to webkit.org | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jon Davis <jond> | ||||
Component: | WebKit Website | Assignee: | Jon Davis <jond> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, jond, timothy, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Jon Davis
2018-12-20 07:36:51 PST
Created attachment 357813 [details]
Patch
Comment on attachment 357813 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357813&action=review > Websites/webkit.org/wp-content/themes/webkit/functions.php:13 > +//add_action( 'wp_header', 'include_invert_lightness_filter'); Remove or uncomment? > Websites/webkit.org/wp-content/themes/webkit/header.php:28 > + <?php include_invert_lightness_filter(); ?> You add it here. > Websites/webkit.org/wp-content/themes/webkit/style.css:17 > + --text-color-coolgray: hsl(240, 2.3%, 56.7%); Having coolgray in the name is not great. Can this get a more semantic name? > Websites/webkit.org/wp-content/themes/webkit/style.css:62 > + --tile-subtle-image-border-shadoww: inset hsla(0, 0%, 0%, 0.1) 0 1px 0 1px; Typo in the name. > Websites/webkit.org/wp-content/themes/webkit/style.css:85 > + --tile-background-color-amber: hsl(48, 100%, 50%); In the list twice. > Websites/webkit.org/wp-content/themes/webkit/style.css:87 > + --gray-tile-text-color: hsl(232.8, 100%, 37.5%); --title-text-color-gray or just --title-text-color? > Websites/webkit.org/wp-content/themes/webkit/style.css:95 > + --figure-mattewhite-background-color: hsl(0, 0%, 100%); Having mattewhite in the name is not great. Can this get a more semantic name? Comment on attachment 357813 [details] Patch Clearing flags on attachment: 357813 Committed r239448: <https://trac.webkit.org/changeset/239448> All reviewed patches have been landed. Closing bug. |