Bug 192918

Summary: Web Inspector: Audits: don't cache default audits
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, hi, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 190754    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Devin Rousso
Reported 2018-12-19 22:52:34 PST
If the localization changes between WebInspector sessions, the default audits should use the new localization instead of the old one, which will be cached along with the audit in the IndexedDB.
Attachments
Patch (1.73 KB, patch)
2018-12-19 22:54 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (2.02 KB, patch)
2018-12-20 09:48 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2018-12-19 22:52:44 PST
<rdar://problem/46626543>
Devin Rousso
Comment 2 2018-12-19 22:54:36 PST
Created attachment 357788 [details] Patch
Blaze Burg
Comment 3 2018-12-20 00:06:01 PST
Comment on attachment 357788 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357788&action=review r=me > Source/WebInspectorUI/ChangeLog:9 > + * UserInterface/Controllers/AuditManager.js: Needs a changelog. For example, explain that by caching you mean using IndexedDB to save the audits. If default audits are not stored in IDB, they will be programmatically recreated every time with UIString labels looked up at runtime using the current locale.
Devin Rousso
Comment 4 2018-12-20 09:48:15 PST
Created attachment 357824 [details] Patch
WebKit Commit Bot
Comment 5 2018-12-20 10:15:54 PST
Comment on attachment 357824 [details] Patch Clearing flags on attachment: 357824 Committed r239449: <https://trac.webkit.org/changeset/239449>
WebKit Commit Bot
Comment 6 2018-12-20 10:15:55 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.