Summary: | Web Inspector: Audits: don't cache default audits | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||
Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bburg, commit-queue, hi, inspector-bugzilla-changes, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | 190754 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Devin Rousso
2018-12-19 22:52:34 PST
Created attachment 357788 [details]
Patch
Comment on attachment 357788 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357788&action=review r=me > Source/WebInspectorUI/ChangeLog:9 > + * UserInterface/Controllers/AuditManager.js: Needs a changelog. For example, explain that by caching you mean using IndexedDB to save the audits. If default audits are not stored in IDB, they will be programmatically recreated every time with UIString labels looked up at runtime using the current locale. Created attachment 357824 [details]
Patch
Comment on attachment 357824 [details] Patch Clearing flags on attachment: 357824 Committed r239449: <https://trac.webkit.org/changeset/239449> All reviewed patches have been landed. Closing bug. |