Bug 192918

Summary: Web Inspector: Audits: don't cache default audits
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, hi, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 190754    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Description Devin Rousso 2018-12-19 22:52:34 PST
If the localization changes between WebInspector sessions, the default audits should use the new localization instead of the old one, which will be cached along with the audit in the IndexedDB.
Comment 1 Devin Rousso 2018-12-19 22:52:44 PST
<rdar://problem/46626543>
Comment 2 Devin Rousso 2018-12-19 22:54:36 PST
Created attachment 357788 [details]
Patch
Comment 3 BJ Burg 2018-12-20 00:06:01 PST
Comment on attachment 357788 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357788&action=review

r=me

> Source/WebInspectorUI/ChangeLog:9
> +        * UserInterface/Controllers/AuditManager.js:

Needs a changelog. For example, explain that by caching you mean using IndexedDB to save the audits. If default audits are not stored in IDB, they will be programmatically recreated every time with UIString labels looked up at runtime using the current locale.
Comment 4 Devin Rousso 2018-12-20 09:48:15 PST
Created attachment 357824 [details]
Patch
Comment 5 WebKit Commit Bot 2018-12-20 10:15:54 PST
Comment on attachment 357824 [details]
Patch

Clearing flags on attachment: 357824

Committed r239449: <https://trac.webkit.org/changeset/239449>
Comment 6 WebKit Commit Bot 2018-12-20 10:15:55 PST
All reviewed patches have been landed.  Closing bug.