Bug 192913

Summary:

UserMedia test should use WKPageNavigationClient

Product:

WebKit

Reporter:

Michael Catanzaro <mcatanzaro>

Component:

Tools / Tests

Assignee:

Michael Catanzaro <mcatanzaro>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, commit-queue, lforschler, mcatanzaro, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

OS:

Linux

Attachments:

Description	Flags
Patch	none

Description Michael Catanzaro 2018-12-19 20:45:43 PST

r239167 "On page close, WebPage::m_userMediaPermissionRequestManager is nullified too early" introduced a deprecation warning:

[452/530] Building CXX object Tools/TestWebKitAPI/C...keFiles/TestWebKit.dir/Tests/WebKit/UserMedia.cpp.o
../../Tools/TestWebKitAPI/Tests/WebKit/UserMedia.cpp: In member function ‘virtual void TestWebKitAPI::WebKit_OnDeviceChangeCrash_Test::TestBody()’:
../../Tools/TestWebKitAPI/Tests/WebKit/UserMedia.cpp:139:66: warning: ‘void WKPageSetPageLoaderClient(WKPageRef, const WKPageLoaderClientBase*)’ is deprecated: use WKPageSetPageNavigationClient [-Wdeprecated-declarations]
     WKPageSetPageLoaderClient(webView2.page(), &loaderClient.base);
                                                                  ^
In file included from DerivedSources/ForwardingHeaders/WebKit/WKPage.h:1,
                 from ../../Source/WebKit/UIProcess/API/C/WebKit2_C.h:53,
                 from DerivedSources/ForwardingHeaders/WebKit/WebKit2_C.h:1,
                 from ../../Tools/TestWebKitAPI/config.h:49,
                 from ../../Tools/TestWebKitAPI/Tests/WebKit/UserMedia.cpp:20:
../../Source/WebKit/UIProcess/API/C/WKPage.h:228:16: note: declared here
 WK_EXPORT void WKPageSetPageLoaderClient(WKPageRef page, const WKPageLoaderClientBase* client) WK_C_API_DEPRECATED_WITH_REPLACEMENT(WKPageSetPageNavigationClient, macosx(WK_MAC_TBA));
                ^~~~~~~~~~~~~~~~~~~~~~~~~
../../Tools/TestWebKitAPI/Tests/WebKit/UserMedia.cpp:139:66: warning: ‘void WKPageSetPageLoaderClient(WKPageRef, const WKPageLoaderClientBase*)’ is deprecated: use WKPageSetPageNavigationClient [-Wdeprecated-declarations]
     WKPageSetPageLoaderClient(webView2.page(), &loaderClient.base);
                                                                  ^
In file included from DerivedSources/ForwardingHeaders/WebKit/WKPage.h:1,
                 from ../../Source/WebKit/UIProcess/API/C/WebKit2_C.h:53,
                 from DerivedSources/ForwardingHeaders/WebKit/WebKit2_C.h:1,
                 from ../../Tools/TestWebKitAPI/config.h:49,
                 from ../../Tools/TestWebKitAPI/Tests/WebKit/UserMedia.cpp:20:
../../Source/WebKit/UIProcess/API/C/WKPage.h:228:16: note: declared here
 WK_EXPORT void WKPageSetPageLoaderClient(WKPageRef page, const WKPageLoaderClientBase* client) WK_C_API_DEPRECATED_WITH_REPLACEMENT(WKPageSetPageNavigationClient, macosx(WK_MAC_TBA));
                ^~~~~~~~~~~~~~~~~~~~~~~~~

Comment 1 Michael Catanzaro 2018-12-19 21:03:47 PST

Created attachment 357774 [details]
Patch

Comment 2 Michael Catanzaro 2019-01-01 12:03:26 PST

Ping reviewers

Comment 3 WebKit Commit Bot 2019-01-03 10:21:06 PST

Comment on attachment 357774 [details]
Patch

Clearing flags on attachment: 357774

Committed r239596: <https://trac.webkit.org/changeset/239596>

Comment 4 WebKit Commit Bot 2019-01-03 10:21:07 PST

All reviewed patches have been landed.  Closing bug.

Comment 5 Radar WebKit Bug Importer 2019-01-03 10:22:27 PST

<rdar://problem/47027896>