Bug 192901

Summary: Adding runtime-enabled attribute to Element prevents inlining property access
Product: WebKit Reporter: Justin Michaud <justin_michaud>
Component: BindingsAssignee: Justin Michaud <justin_michaud>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, rniwa, saam, tsavell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Justin Michaud
Reported 2018-12-19 16:52:25 PST
This test <https://trac.webkit.org/browser/trunk/LayoutTests/js/dom/domjit-function-get-element-by-id.html> started failing after this patch <>. See https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=js%2Fdom%2Fdomjit-function-get-element-by-id.html Saam suggested calling flattenDictionaryObject should fix this, and it seems to work.
Attachments
Patch (17.91 KB, patch)
2018-12-19 17:06 PST, Justin Michaud 		no flags
DetailsFormatted DiffDiff
Patch (17.85 KB, patch)
2018-12-19 21:35 PST, Justin Michaud 		no flags
DetailsFormatted DiffDiff
Patch (17.87 KB, patch)
2018-12-20 09:43 PST, Justin Michaud 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Justin Michaud
Comment 1 2018-12-19 17:06:59 PST
Created attachment 357761 [details] Patch
Justin Michaud
Comment 2 2018-12-19 21:35:49 PST
Created attachment 357778 [details] Patch
Saam Barati
Comment 3 2018-12-19 23:21:06 PST
Comment on attachment 357778 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357778&action=review > Source/WebCore/ChangeLog:3 > + Adding runtime-enabled attribute to Element prevents inlining I’d saying “inlining property access” here.
Justin Michaud
Comment 4 2018-12-20 09:43:36 PST
Created attachment 357822 [details] Patch
WebKit Commit Bot
Comment 5 2018-12-20 17:33:22 PST
Comment on attachment 357822 [details] Patch Clearing flags on attachment: 357822 Committed r239483: <https://trac.webkit.org/changeset/239483>
WebKit Commit Bot
Comment 6 2018-12-20 17:33:25 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-12-20 17:34:27 PST
<rdar://problem/46888953>
Saam Barati
Comment 8 2019-01-08 11:46:44 PST
This was also a 7% progression on the "Dromaeo CSS Selector" test.
Ryosuke Niwa
Comment 9 2019-01-09 14:02:50 PST
(In reply to Saam Barati from comment #8) > This was also a 7% progression on the "Dromaeo CSS Selector" test. Nice!
Note You need to log in before you can comment on or make changes to this bug.