Bug 192840

Summary: SVGUseElement::findTarget should return nullptr when there is a cycle
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: SVGAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: koivisto, sabouhallawa, simon.fraser, thorton, webkit-bug-importer, zalan, zimmermann
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Cleanup thorton: review+

Description Ryosuke Niwa 2018-12-18 19:20:53 PST 
https://trac.webkit.org/changeset/233366 added an early return to updateShadowTree() when there is a cycle
but there is a separate cycle detection for when there is a corresponding element in SVGUseElement::findTarget.

Support detecting a cycle in SVGUseElement::findTarget to consolidate these two cycle detection code paths.
Comment 1 Ryosuke Niwa 2018-12-18 19:49:01 PST 
Created attachment 357647 [details]
Cleanup
Comment 2 Tim Horton 2018-12-19 14:30:39 PST 
Comment on attachment 357647 [details]
Cleanup

View in context: https://bugs.webkit.org/attachment.cgi?id=357647&action=review

> Source/WebCore/ChangeLog:12
> +        No new tests since there shoul be no behavioral change.

s/shoul/should/
Comment 3 Ryosuke Niwa 2018-12-19 15:51:06 PST 
Committed r239402: <https://trac.webkit.org/changeset/239402>
Comment 4 Radar WebKit Bug Importer 2018-12-19 15:52:26 PST 
<rdar://problem/46855832>