| Summary: | REGRESSION(r239134) iOS safe browsing warning unable to show details | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | thorton, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Alex Christensen
2018-12-18 16:03:26 PST
Created attachment 357628 [details]
Patch
Comment on attachment 357628 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357628&action=review > Source/WebKit/ChangeLog:10 > + I added a call to updateContentSize in r239134 which was necessary on watchOS but it makes iOS unable to show the details. Why?!?! It was necessary on the watch because the content is bigger than a watch screen and you need to scroll down to see or do anything. I don't know why setting the size on the watch twice works fine but on iOS it does not. Seems like it would be good to know that? Especially since it's just "do a layout and set contentSize" which should certainly not break things? Created attachment 357637 [details]
Patch
|