Bug 192835

Summary: [WebAuthN] userPresence should always be true
Product: WebKit Reporter: Jiewen Tan <jiewen_tan>
Component: WebCore Misc.Assignee: Jiewen Tan <jiewen_tan>
Status: RESOLVED FIXED    
Severity: Normal CC: alex.gaynor, bfulgham, cdumez, commit-queue, jiewen_tan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 181943    
Attachments:
Description Flags
Patch
none
Patch
bfulgham: review+
Patch for landing none

Description Jiewen Tan 2018-12-18 15:32:06 PST 
In the current spec, userPresence is suggested to set to the inverse of userVerification, which doesn't comply with the CTAP spec. Details in: https://github.com/w3c/webauthn/issues/1123.
Comment 1 Jiewen Tan 2018-12-18 15:51:23 PST 
<rdar://problem/46538788>
Comment 2 Jiewen Tan 2018-12-20 17:34:46 PST 
Created attachment 357908 [details]
Patch
Comment 3 Jiewen Tan 2018-12-20 17:39:06 PST 
Created attachment 357909 [details]
Patch
Comment 4 Jiewen Tan 2018-12-20 17:40:51 PST 
My suggestion is seconded by Yubico and Microsoft directly on GitHub, and Google via email.
Comment 5 Brent Fulgham 2018-12-21 14:24:32 PST 
Comment on attachment 357909 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357909&action=review

r=me

> Source/WebCore/ChangeLog:11
> +        The change is made to follow my suggestion in the issue as no one has objected it.

"After discussing with other members of the working group, we decided to make userPresence always default to true."
Comment 6 Jiewen Tan 2018-12-21 14:44:25 PST 
Comment on attachment 357909 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357909&action=review

Thanks Brent for r+ this patch.

>> Source/WebCore/ChangeLog:11
>> +        The change is made to follow my suggestion in the issue as no one has objected it.
> 
> "After discussing with other members of the working group, we decided to make userPresence always default to true."

Fixed.
Comment 7 Jiewen Tan 2018-12-21 14:48:46 PST 
Created attachment 357983 [details]
Patch for landing
Comment 8 WebKit Commit Bot 2018-12-21 15:27:36 PST 
Comment on attachment 357983 [details]
Patch for landing

Clearing flags on attachment: 357983

Committed r239523: <https://trac.webkit.org/changeset/239523>