| Summary: | Error message for `-x ** y` contains a typo. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ross Kirsling <ross.kirsling> | ||||||
| Component: | JavaScriptCore | Assignee: | Ross Kirsling <ross.kirsling> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer, ysuzuki | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Ross Kirsling
2018-12-18 15:25:15 PST
Created attachment 357623 [details]
Patch
Comment on attachment 357623 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357623&action=review > Source/JavaScriptCore/parser/Parser.cpp:3889 > - failIfTrue(match(POW) && isUnaryOpExcludingUpdateOp(leadingTokenTypeForUnaryExpression), "Amiguous unary expression in the left hand side of the exponentiation expression; parenthesis must be used to disambiguate the expression"); > + failIfTrue(match(POW) && isUnaryOpExcludingUpdateOp(leadingTokenTypeForUnaryExpression), "Ambiguous unary expression in the left hand side of the exponentiation expression; parenthesis must be used to disambiguate the expression"); Hmm, if we're fixing this string anyway, I suppose "parenthesis must be used" -> "parentheses must be used" would be better too... Comment on attachment 357623 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357623&action=review >> Source/JavaScriptCore/parser/Parser.cpp:3889 >> + failIfTrue(match(POW) && isUnaryOpExcludingUpdateOp(leadingTokenTypeForUnaryExpression), "Ambiguous unary expression in the left hand side of the exponentiation expression; parenthesis must be used to disambiguate the expression"); > > Hmm, if we're fixing this string anyway, I suppose "parenthesis must be used" -> "parentheses must be used" would be better too... r=me with this change Created attachment 357654 [details]
Patch for landing
Comment on attachment 357654 [details] Patch for landing Clearing flags on attachment: 357654 Committed r239370: <https://trac.webkit.org/changeset/239370> All reviewed patches have been landed. Closing bug. |