Bug 192827

Summary:

[MSE] Remove dead code: sourceBufferPrivateSeekToTime()

Product:

WebKit

Reporter:

Alicia Boya García <aboya>

Component:

Media

Assignee:

Alicia Boya García <aboya>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

calvaris, commit-queue, darin, jer.noble, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Alicia Boya García

Reported 2018-12-18 13:22:22 PST

This patch makes two dead code removal changes in SourceBufferPrivateClient: First, sourceBufferPrivateFastSeekTimeForMediaTime() is made pure virtual in SourceBufferPrivateClient. Since SourceBufferPrivateClient is only inherited by SourceBuffer, it makes no sense to have default implementations there (they will never be used), moreso it being a client interface. Second, sourceBufferPrivateSeekToTime() is removed entirely. It used to had an empty implementation, which SourceBuffer did not overwrite, therefore making any calls to it useless. All calls to sourceBufferPrivateSeekToTime() have been removed: SourceBufferPrivateAVFObjC::seekToTime(), which was also dead code itself, used to call this method. This patch deletes it completely. MockSourceBufferPrivate::seekToTime(), which only called this empty method, has also been removed along with its only usage in MockMediaSourcePrivate::seekToTime().

Attachments
Patch (6.89 KB, patch) 2018-12-18 13:28 PST, Alicia Boya García	no flags	Details Formatted Diff Diff
Patch (6.93 KB, patch) 2018-12-18 13:40 PST, Alicia Boya García	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.