|Summary:||[MSE] Remove dead code: sourceBufferPrivateSeekToTime()|
|Product:||WebKit||Reporter:||Alicia Boya García <aboya>|
|Component:||Media||Assignee:||Alicia Boya García <aboya>|
|Severity:||Normal||CC:||calvaris, commit-queue, darin, jer.noble, webkit-bug-importer|
|Version:||WebKit Nightly Build|
Description Alicia Boya García 2018-12-18 13:22:22 PST
This patch makes two dead code removal changes in SourceBufferPrivateClient: First, sourceBufferPrivateFastSeekTimeForMediaTime() is made pure virtual in SourceBufferPrivateClient. Since SourceBufferPrivateClient is only inherited by SourceBuffer, it makes no sense to have default implementations there (they will never be used), moreso it being a client interface. Second, sourceBufferPrivateSeekToTime() is removed entirely. It used to had an empty implementation, which SourceBuffer did not overwrite, therefore making any calls to it useless. All calls to sourceBufferPrivateSeekToTime() have been removed: SourceBufferPrivateAVFObjC::seekToTime(), which was also dead code itself, used to call this method. This patch deletes it completely. MockSourceBufferPrivate::seekToTime(), which only called this empty method, has also been removed along with its only usage in MockMediaSourcePrivate::seekToTime().
Comment 3 Xabier Rodríguez Calvar 2018-12-19 02:53:33 PST
Comment on attachment 357606 [details] Patch r+ of me and Jer, who I think forgot to set the proper flag :)
Comment 4 WebKit Commit Bot 2018-12-19 03:20:23 PST
Comment on attachment 357606 [details] Patch Clearing flags on attachment: 357606 Committed r239374: <https://trac.webkit.org/changeset/239374>
Comment 5 WebKit Commit Bot 2018-12-19 03:20:25 PST
All reviewed patches have been landed. Closing bug.