[MSE] Remove dead code: sourceBufferPrivateSeekToTime()

• Component: Media
• Status: RESOLVED FIXED

[Alicia Boya García]

This patch makes two dead code removal changes in
SourceBufferPrivateClient:

First, sourceBufferPrivateFastSeekTimeForMediaTime() is made pure
virtual in SourceBufferPrivateClient. Since SourceBufferPrivateClient
is only inherited by SourceBuffer, it makes no sense to have default
implementations there (they will never be used), moreso it being a
client interface.

Second, sourceBufferPrivateSeekToTime() is removed entirely. It used
to had an empty implementation, which SourceBuffer did not overwrite,
therefore making any calls to it useless.

All calls to sourceBufferPrivateSeekToTime() have been removed:

SourceBufferPrivateAVFObjC::seekToTime(), which was also dead code
itself, used to call this method. This patch deletes it completely.

MockSourceBufferPrivate::seekToTime(), which only called this empty
method, has also been removed along with its only usage in
MockMediaSourcePrivate::seekToTime().

[Alicia Boya García]

Created attachment 357604 [details]
Patch

[Alicia Boya García]

Created attachment 357606 [details]
Patch

[Xabier Rodríguez Calvar]

Comment on attachment 357606 [details]
Patch

r+ of me and Jer, who I think forgot to set the proper flag :)

[WebKit Commit Bot]

Comment on attachment 357606 [details]
Patch

Clearing flags on attachment: 357606

Committed r239374: <https://trac.webkit.org/changeset/239374>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/46837338>