Summary: | REGRESSION: [iOS] API test TestWebKitAPI._WKDownload.OriginatingWebView is a flaky failure | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryan Haddad <ryanhaddad> | ||||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | achristensen, ap, commit-queue, david_quesada, jlewis3, tsavell, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | Other | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Ryan Haddad
2018-12-18 09:31:27 PST
It failed about 50% of the time for me locally when I ran: run-api-tests --debug --ios-simulator _WKDownload.OriginatingWebView When I see this fail, it doesn't appear that the originatingWebView has any remaining strong references, but is in the autorelease pool, likely as a result of handling other messages that have been sent to the UI process while the test has run. The test seems to pass (I've hit at least 20 successes in a row, compared to 3/10 successes without any changes) if I defer checking the originatingWebView to the next turn of the runloop. Patch coming up. Created attachment 357614 [details]
Patch
Comment on attachment 357614 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357614&action=review > Tools/TestWebKitAPI/Tests/WebKitCocoa/Download.mm:260 > + WTF::callOnMainThread([retainedDownload = RetainPtr<_WKDownload> { download }] { [download = retainPtr(download)] Created attachment 357621 [details]
Patch for landing
Comment on attachment 357621 [details] Patch for landing Clearing flags on attachment: 357621 Committed r239359: <https://trac.webkit.org/changeset/239359> All reviewed patches have been landed. Closing bug. |