Bug 192786

Summary: webkitpy: Ignore device type for test when using --force
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dbates, ews-watchlist, glenn, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Jonathan Bedard
Reported 2018-12-17 16:29:52 PST
There are cases where a contributor may wish to ignore the device type associated with a test. This fits with the description of the existing --force flag.
Attachments
Patch (2.54 KB, patch)
2018-12-17 16:37 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (3.03 KB, patch)
2018-12-17 16:50 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.20 KB, patch)
2018-12-18 11:04 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-12-17 16:30:28 PST
<rdar://problem/46794894>
Jonathan Bedard
Comment 2 2018-12-17 16:37:46 PST
Created attachment 357498 [details] Patch
Jonathan Bedard
Comment 3 2018-12-17 16:50:33 PST
Created attachment 357502 [details] Patch
Daniel Bates
Comment 4 2018-12-18 10:41:53 PST
Comment on attachment 357502 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357502&action=review > Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:245 > + help="Run all tests with PASS as expected result, even those marked SKIP in the test list and run tests " + \ > + "on available devices, even if the device type does not match (implies --skipped=ignore)"), The wording of this text is confusing and I had to read it over a few times for it to make sense to me. Maybe it would be clearer to write: "Run all tests with PASS as expected result, even those marked SKIP in the test list or are device-specific (implies --skipped=ignore)".
Daniel Bates
Comment 5 2018-12-18 10:42:43 PST
Comment on attachment 357502 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357502&action=review > Tools/ChangeLog:8 > + A good change log message describes why we are making the change in addition to what the change is.
Jonathan Bedard
Comment 6 2018-12-18 11:04:32 PST
Created attachment 357583 [details] Patch for landing
WebKit Commit Bot
Comment 7 2018-12-18 11:43:05 PST
Comment on attachment 357583 [details] Patch for landing Clearing flags on attachment: 357583 Committed r239344: <https://trac.webkit.org/changeset/239344>
WebKit Commit Bot
Comment 8 2018-12-18 11:43:06 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.