webkitpy: Ignore device type for test when using --force

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Jonathan Bedard]

There are cases where a contributor may wish to ignore the device type associated with a test. This fits with the description of the existing --force flag.

[Radar WebKit Bug Importer]

<rdar://problem/46794894>

[Jonathan Bedard]

Created attachment 357498 [details]
Patch

[Jonathan Bedard]

Created attachment 357502 [details]
Patch

[Daniel Bates]

Comment on attachment 357502 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357502&action=review

> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:245
> +            help="Run all tests with PASS as expected result, even those marked SKIP in the test list and run tests " + \
> +                 "on available devices, even if the device type does not match (implies --skipped=ignore)"),

The wording of this text is confusing and I had to read it over a few times for it to make sense to me. Maybe it would be clearer to write: "Run all tests with PASS as expected result, even those marked SKIP in the test list or are device-specific (implies --skipped=ignore)".

[Daniel Bates]

Comment on attachment 357502 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357502&action=review

> Tools/ChangeLog:8
> +

A good change log message describes why we are making the change in addition to what the change is.

[Jonathan Bedard]

Created attachment 357583 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 357583 [details]
Patch for landing

Clearing flags on attachment: 357583

Committed r239344: <https://trac.webkit.org/changeset/239344>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.