Bug 192775

Summary:

webkitpy: Handle case where stdout and stderr don't accept unicode

Product:

WebKit

Reporter:

Jonathan Bedard <jbedard>

Component:

Tools / Tests

Assignee:

Jonathan Bedard <jbedard>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, commit-queue, ews-watchlist, glenn, lforschler, rniwa, slewis, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Jonathan Bedard 2018-12-17 13:47:21 PST

It turns out that while the terminal accepts unicode characters, buildbot's stdout and stderr does not. We should handle this case in the MeteredStream object.

Comment 1 Radar WebKit Bug Importer 2018-12-17 13:47:43 PST

<rdar://problem/46788706>

Comment 2 Jonathan Bedard 2018-12-17 13:54:13 PST

Created attachment 357473 [details]
Patch

Comment 3 WebKit Commit Bot 2018-12-17 16:12:13 PST

Comment on attachment 357473 [details]
Patch

Clearing flags on attachment: 357473

Committed r239303: <https://trac.webkit.org/changeset/239303>

Comment 4 WebKit Commit Bot 2018-12-17 16:12:15 PST

All reviewed patches have been landed.  Closing bug.