| Summary: | Fix occasional null-dereference crash in WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrame | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cdumez, commit-queue, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Alex Christensen
2018-12-15 15:49:49 PST
Created attachment 357408 [details]
Patch
Comment on attachment 357408 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357408&action=review > Source/WebKit/ChangeLog:5 > + <rdar://problem/45842668> I believe I fixed this crash in https://trac.webkit.org/changeset/238565 already, with a test. Comment on attachment 357408 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357408&action=review >> Source/WebKit/ChangeLog:5 >> + <rdar://problem/45842668> > > I believe I fixed this crash in https://trac.webkit.org/changeset/238565 already, with a test. You did not. This crash has been seen since then. Comment on attachment 357408 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357408&action=review >>> Source/WebKit/ChangeLog:5 >>> + <rdar://problem/45842668> >> >> I believe I fixed this crash in https://trac.webkit.org/changeset/238565 already, with a test. > > You did not. This crash has been seen since then. Crash trace is actually different but yes. Comment on attachment 357408 [details] Patch Clearing flags on attachment: 357408 Committed r239305: <https://trac.webkit.org/changeset/239305> All reviewed patches have been landed. Closing bug. |