Bug 192740

Summary: [WPE][GTK] Add libpsl to JHBuild module sets
Product: WebKit Reporter: Adrian Perez <aperez>
Component: Tools / TestsAssignee: Adrian Perez <aperez>
Status: RESOLVED FIXED    
Severity: Normal CC: agomez, cgarcia, clopez, ews-watchlist, lforschler, ltilve, mcatanzaro, webkit-bug-importer, zan
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch v2 mcatanzaro: review+, mcatanzaro: commit-queue-

Adrian Perez
Reported 2018-12-15 04:37:14 PST
Most of the bots (and in particular the EWS ones!) are running on Debian stable, which has libpsl 0.15.0; but that is too old as the glib-networking version installed in the JHBuild requires version 0.20.0. Unfortunately, the Debian backports repository does not have packages for newer libpsl versions either, so we need to add it to the JHBuild module sets for the WPE and GTK+ ports. This is needed to unbreak our EWS bots as well.
Attachments
Patch (2.31 KB, patch)
2018-12-15 04:42 PST, Adrian Perez 		no flags
DetailsFormatted DiffDiff
Patch v2 (2.32 KB, patch)
2018-12-15 07:45 PST, Adrian Perez 		mcatanzaro: review+
mcatanzaro: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adrian Perez
Comment 1 2018-12-15 04:42:25 PST
Created attachment 357398 [details] Patch
Adrian Perez
Comment 2 2018-12-15 07:45:47 PST
Created attachment 357402 [details] Patch v2
Michael Catanzaro
Comment 3 2018-12-15 09:47:40 PST
Comment on attachment 357402 [details] Patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=357402&action=review > Tools/gtk/jhbuild.modules:235 > + <dep package="libpsl/"/> It's a dependency of libsoup, not glib-networking. Please fix before landing! Sorry I didn't notice this yesterday....
Adrian Perez
Comment 4 2018-12-15 15:01:48 PST
Committed r239253: <https://trac.webkit.org/changeset/239253>
Radar WebKit Bug Importer
Comment 5 2018-12-15 15:03:12 PST
<rdar://problem/46757064>
Note You need to log in before you can comment on or make changes to this bug.