Bug 19274

Summary: wxWebKit compile error on linux x86_64
Product: WebKit Reporter: Malcolm MacLeod <mmacleod>
Component: WebKit wxAssignee: Malcolm MacLeod <mmacleod>
Status: RESOLVED DUPLICATE    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: Other   
OS: Linux   
Attachments:
Description Flags
Compile fix for x86_64 platforms none

Malcolm MacLeod
Reported 2008-05-27 12:26:45 PDT
SVN Trunk version of wxWebKit fails to compile on x86_64 platforms due to relying on a cast from pointer to int in order to generate font keys. The attached file provides a fix that works around this. The patch is not 100% ideal as it could lead to conflicts in keys in very rare circumstances.
Attachments
Compile fix for x86_64 platforms (1.05 KB, patch)
2008-05-27 12:33 PDT, Malcolm MacLeod 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Malcolm MacLeod
Comment 1 2008-05-27 12:33:34 PDT
Created attachment 21368 [details] Compile fix for x86_64 platforms
Alexey Proskuryakov
Comment 2 2008-05-28 06:04:52 PDT
A better way to fix this would be by using PtrHash: return PtrHash<wxFont*>::hash(&m_font); This class appears broken in that it computes m_fontHash and never uses it later, and also includes hash table machinery that should be in hash traits instead, but fixing that is out of scope for a simple bug fix. Please do not use tab characters in your patch.
Alexey Proskuryakov
Comment 3 2008-06-09 07:52:09 PDT
Fixed by fixing the hash function itself. *** This bug has been marked as a duplicate of 19310 ***
Note You need to log in before you can comment on or make changes to this bug.