Bug 192703

Summary: Add a style checker rule for Xcode version macros use
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, ews-watchlist, glenn, lforschler, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch none

Alexey Proskuryakov
Reported 2018-12-14 09:46:06 PST
Check MIX_REQUIRED and MAX_ALLOWED family of macros.
Attachments
proposed patch (6.49 KB, patch)
2018-12-14 09:48 PST, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2018-12-14 09:48:45 PST
Created attachment 357320 [details] proposed patch
WebKit Commit Bot
Comment 2 2018-12-14 23:52:03 PST
Comment on attachment 357320 [details] proposed patch Clearing flags on attachment: 357320 Committed r239250: <https://trac.webkit.org/changeset/239250>
WebKit Commit Bot
Comment 3 2018-12-14 23:52:04 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2018-12-14 23:53:26 PST
<rdar://problem/46751789>
Tim Horton
Comment 5 2020-03-25 22:35:48 PDT
Comment on attachment 357320 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=357320&action=review > Tools/Scripts/webkitpy/style/checkers/cpp.py:1107 > + 2. VERSION_MIN_REQUIRED never changes for a minor OS version. This is not globally true, right? Only for macOS.
Alexey Proskuryakov
Comment 6 2020-03-26 09:24:32 PDT
I think that you are right. I don't know how deployment target is communicated to clang (is it -target or an invisible environment variable, and how does it interact with -mmacosx-version-min?), so I'm not confident enough to rewrite this comment.
Note You need to log in before you can comment on or make changes to this bug.