Bug 192701 – [PSON] Stop exposing PolicyAction::Suspend to WebCore

• Component: WebKit2
• Status: RESOLVED FIXED

[Chris Dumez]

Stop exposing PolicyAction::Suspend to WebCore as this is a WebKit2-layer concept.

[Chris Dumez]

Created attachment 357319 [details]
Patch

[Chris Dumez]

Comment on attachment 357319 [details]
Patch

Clearing flags on attachment: 357319

Committed r239219: <https://trac.webkit.org/changeset/239219>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/46734047>

[Adrian Perez]

(In reply to Chris Dumez from comment #2)
> Comment on attachment 357319 [details]
> Patch
> 
> Clearing flags on attachment: 357319
> 
> Committed r239219: <https://trac.webkit.org/changeset/239219>

This broke the build for both the GTK+ and WPE ports, I have
pushed a fix in https://trac.webkit.org/changeset/239225

Please *do* wait for all the EWS bots to run on your patches,
this would have been caught by them. I can spin a couple of
bots more for our ports if needed -- just let me know :)

[Chris Dumez]

(In reply to Adrian Perez from comment #5)
> (In reply to Chris Dumez from comment #2)
> > Comment on attachment 357319 [details]
> > Patch
> > 
> > Clearing flags on attachment: 357319
> > 
> > Committed r239219: <https://trac.webkit.org/changeset/239219>
> 
> This broke the build for both the GTK+ and WPE ports, I have
> pushed a fix in https://trac.webkit.org/changeset/239225
> 
> Please *do* wait for all the EWS bots to run on your patches,
> this would have been caught by them. I can spin a couple of
> bots more for our ports if needed -- just let me know :)

I apologize as I normally try to do that. However:
1. The GTK/WPE EWS was in a bad state and failing to build *without* my change
2. We still have rules in place (AFAIK) allow WK2 changes to break other ports.

[Adrian Perez]

(In reply to Chris Dumez from comment #6)
> (In reply to Adrian Perez from comment #5)
> > (In reply to Chris Dumez from comment #2)
> > > Comment on attachment 357319 [details]
> > > Patch
> > > 
> > > Clearing flags on attachment: 357319
> > > 
> > > Committed r239219: <https://trac.webkit.org/changeset/239219>
> > 
> > This broke the build for both the GTK+ and WPE ports, I have
> > pushed a fix in https://trac.webkit.org/changeset/239225
> > 
> > Please *do* wait for all the EWS bots to run on your patches,
> > this would have been caught by them. I can spin a couple of
> > bots more for our ports if needed -- just let me know :)
> 
> I apologize as I normally try to do that. However:
> 1. The GTK/WPE EWS was in a bad state and failing to build *without* my
> change
> 2. We still have rules in place (AFAIK) allow WK2 changes to break other
> ports.

No problem, it was just a gentle reminder. Thanks a lot for the
heads up about our EWS bots behaving funnily; if they did that
it's understandable that you went ahead and landed -- I will get
my stethoscope and see if there's something wrong with the bots :)

[Chris Dumez]

(In reply to Adrian Perez from comment #7)
> (In reply to Chris Dumez from comment #6)
> > (In reply to Adrian Perez from comment #5)
> > > (In reply to Chris Dumez from comment #2)
> > > > Comment on attachment 357319 [details]
> > > > Patch
> > > > 
> > > > Clearing flags on attachment: 357319
> > > > 
> > > > Committed r239219: <https://trac.webkit.org/changeset/239219>
> > > 
> > > This broke the build for both the GTK+ and WPE ports, I have
> > > pushed a fix in https://trac.webkit.org/changeset/239225
> > > 
> > > Please *do* wait for all the EWS bots to run on your patches,
> > > this would have been caught by them. I can spin a couple of
> > > bots more for our ports if needed -- just let me know :)
> > 
> > I apologize as I normally try to do that. However:
> > 1. The GTK/WPE EWS was in a bad state and failing to build *without* my
> > change
> > 2. We still have rules in place (AFAIK) allow WK2 changes to break other
> > ports.
> 
> No problem, it was just a gentle reminder. Thanks a lot for the
> heads up about our EWS bots behaving funnily; if they did that
> it's understandable that you went ahead and landed -- I will get
> my stethoscope and see if there's something wrong with the bots :)

If it helps, here is what the output looked like:
https://webkit-queues.webkit.org/results/10398265

No such file or directory at /home/ews/igalia-wpe-ews/WebKit/Tools/Scripts/webkitdirs.pm line 2338.

[Adrian Perez]

(In reply to Chris Dumez from comment #8)

> If it helps, here is what the output looked like:
> https://webkit-queues.webkit.org/results/10398265
> 
> No such file or directory at
> /home/ews/igalia-wpe-ews/WebKit/Tools/Scripts/webkitdirs.pm line 2338.

Thanks, I have been reanimating our EWS bots yesterday, and after
landing a couple of fixes and cleaning up the build directories
they seem to be working all fine except one to which I don't have
access right now. I'll get to it tomorrow when people show up online
at European office hours =)