Bug 192692

Summary: [LFC][BFC] Introduce VerticalMargin and HorizontalMargin types.
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch koivisto: review+

alan
Reported 2018-12-13 21:01:23 PST
This is in preparation for adding more block collapsing functionality.
Attachments
Patch (35.65 KB, patch)
2018-12-13 21:07 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (35.52 KB, patch)
2018-12-13 21:48 PST, alan 		koivisto: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2018-12-13 21:07:39 PST
Created attachment 357297 [details] Patch
alan
Comment 2 2018-12-13 21:48:46 PST
Created attachment 357300 [details] Patch
Antti Koivisto
Comment 3 2018-12-14 06:46:18 PST
Comment on attachment 357300 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357300&action=review > Source/WebCore/layout/FormattingContext.h:100 > + static HorizontalMargin computedNonCollapsedHorizontalMarginValue(const LayoutState&, const Box&); > + static VerticalMargin::ComputedValues computedNonCollapsedVerticalMarginValue(const LayoutState&, const Box&); Maybe HorizontalMargin can be ComputedHorizontalMargin?
alan
Comment 4 2018-12-14 07:18:16 PST
(In reply to Antti Koivisto from comment #3) > Comment on attachment 357300 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=357300&action=review > > > Source/WebCore/layout/FormattingContext.h:100 > > + static HorizontalMargin computedNonCollapsedHorizontalMarginValue(const LayoutState&, const Box&); > > + static VerticalMargin::ComputedValues computedNonCollapsedVerticalMarginValue(const LayoutState&, const Box&); > > Maybe HorizontalMargin can be ComputedHorizontalMargin? Yeah, good idea. I've got a fixme on the non-computed horizontal margin value. Let me fix the together.
alan
Comment 5 2018-12-14 07:22:09 PST
Committed r239205: <https://trac.webkit.org/changeset/239205>
Radar WebKit Bug Importer
Comment 6 2018-12-14 07:23:27 PST
<rdar://problem/46729951>
Note You need to log in before you can comment on or make changes to this bug.