[LFC][BFC] Introduce VerticalMargin and HorizontalMargin types.

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[zalan]

This is in preparation for adding more block collapsing functionality.

[zalan]

Created attachment 357297 [details]
Patch

[zalan]

Created attachment 357300 [details]
Patch

[Antti Koivisto]

Comment on attachment 357300 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357300&action=review

> Source/WebCore/layout/FormattingContext.h:100
> +        static HorizontalMargin computedNonCollapsedHorizontalMarginValue(const LayoutState&, const Box&);
> +        static VerticalMargin::ComputedValues computedNonCollapsedVerticalMarginValue(const LayoutState&, const Box&);

Maybe HorizontalMargin can be ComputedHorizontalMargin?

[zalan]

(In reply to Antti Koivisto from comment #3)
> Comment on attachment 357300 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=357300&action=review
> 
> > Source/WebCore/layout/FormattingContext.h:100
> > +        static HorizontalMargin computedNonCollapsedHorizontalMarginValue(const LayoutState&, const Box&);
> > +        static VerticalMargin::ComputedValues computedNonCollapsedVerticalMarginValue(const LayoutState&, const Box&);
> 
> Maybe HorizontalMargin can be ComputedHorizontalMargin?
Yeah, good idea. I've got a fixme on the non-computed horizontal margin value. Let me fix the together.

[zalan]

Committed r239205: <https://trac.webkit.org/changeset/239205>

[Radar WebKit Bug Importer]

<rdar://problem/46729951>