Bug 192660

Summary: Improve GDB output for LLInt on Linux
Product: WebKit Reporter: Dominik Inführ <dominik.infuehr>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Dominik Inführ
Reported 2018-12-13 01:31:11 PST
Improve GDB output for LLInt on Linux
Attachments
Patch (2.82 KB, patch)
2018-12-13 01:43 PST, Dominik Inführ 		no flags
DetailsFormatted DiffDiff
Patch (2.88 KB, patch)
2018-12-13 04:08 PST, Dominik Inführ 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dominik Inführ
Comment 1 2018-12-13 01:43:15 PST
Created attachment 357220 [details] Patch
Yusuke Suzuki
Comment 2 2018-12-13 02:40:21 PST
Comment on attachment 357220 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357220&action=review > Source/JavaScriptCore/offlineasm/arm.rb:687 > + offsetLabel = ".L_offlineasm_arm_got_offset_#{uid}" Does this break OS(DARWIN)? See wtf/InlineASM.h's LOCAL_LABEL_STRING definition.
Dominik Inführ
Comment 3 2018-12-13 04:08:12 PST
Created attachment 357223 [details] Patch
Dominik Inführ
Comment 4 2018-12-13 04:11:46 PST
True, I didn't expect it to be used on OS(DARWIN) since I've only added `globaladdr` for ARM recently. But I've updated it to use `Assembler.localLabellReference`, should be a bit simpler.
Yusuke Suzuki
Comment 5 2018-12-13 07:29:24 PST
Comment on attachment 357223 [details] Patch r=me
WebKit Commit Bot
Comment 6 2018-12-13 23:17:39 PST
Comment on attachment 357223 [details] Patch Clearing flags on attachment: 357223 Committed r239199: <https://trac.webkit.org/changeset/239199>
WebKit Commit Bot
Comment 7 2018-12-13 23:17:41 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.