Bug 192638

Summary: [macOS] Inline WebVTT styles should override styles from Captions settings in System Preferences
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebCore Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, eric.carlson, koivisto
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Per Arne Vollan
Reported 2018-12-12 13:44:58 PST
It should be possible to override styles generated from Captions settings in System Preferences with inline WebVTT styles when ‘Allow video to override’ is checked in System Preferences.
Attachments
Patch (11.29 KB, patch)
2018-12-12 14:00 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (11.81 KB, patch)
2018-12-12 15:05 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (11.82 KB, patch)
2018-12-12 16:24 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2018-12-12 13:45:19 PST
rdar://problem/46421091
Per Arne Vollan
Comment 2 2018-12-12 14:00:00 PST
Created attachment 357165 [details] Patch
Per Arne Vollan
Comment 3 2018-12-12 15:05:27 PST
Created attachment 357172 [details] Patch
Per Arne Vollan
Comment 4 2018-12-12 16:24:38 PST
Created attachment 357190 [details] Patch
Per Arne Vollan
Comment 5 2018-12-13 14:40:13 PST
Comment on attachment 357190 [details] Patch Thanks for reviewing!
WebKit Commit Bot
Comment 6 2018-12-13 15:06:56 PST
Comment on attachment 357190 [details] Patch Clearing flags on attachment: 357190 Committed r239181: <https://trac.webkit.org/changeset/239181>
WebKit Commit Bot
Comment 7 2018-12-13 15:06:57 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.