Bug 192625

Summary: [LFC][BFC][MarginCollapsing] Add support for peculiar cases.
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, koivisto, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

zalan
Reported 2018-12-12 07:49:15 PST
name a couple: If the top and bottom margins of an element with clearance are adjoining, its margins collapse with the adjoining margins of following siblings but that resulting margin does not collapse with the bottom margin of the parent block. If the top margin of a box with non-zero computed 'min-height' and 'auto' computed 'height' collapses with the bottom margin of its last in-flow child, then the child's bottom margin does not collapse with the parent's bottom margin.
Attachments
Patch (79.47 KB, patch)
2018-12-12 08:00 PST, zalan 		no flags
DetailsFormatted DiffDiff
Patch (67.00 KB, patch)
2018-12-16 18:00 PST, zalan 		no flags
DetailsFormatted DiffDiff
Patch (124.13 KB, patch)
2018-12-29 08:46 PST, zalan 		no flags
DetailsFormatted DiffDiff
Patch (110.67 KB, patch)
2018-12-29 09:13 PST, zalan 		no flags
DetailsFormatted DiffDiff
Patch (111.87 KB, patch)
2018-12-29 18:12 PST, zalan 		no flags
DetailsFormatted DiffDiff
Patch (83.76 KB, patch)
2018-12-29 18:23 PST, zalan 		no flags
DetailsFormatted DiffDiff
Patch (111.33 KB, patch)
2018-12-29 20:06 PST, zalan 		no flags
DetailsFormatted DiffDiff
Patch (92.56 KB, patch)
2019-01-05 21:21 PST, zalan 		no flags
DetailsFormatted DiffDiff
Patch (85.22 KB, patch)
2019-01-06 21:48 PST, zalan 		no flags
DetailsFormatted DiffDiff
Patch (87.13 KB, patch)
2019-01-08 07:47 PST, zalan 		no flags
DetailsFormatted DiffDiff
Patch (90.37 KB, patch)
2019-01-08 21:32 PST, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (10) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2018-12-12 08:00:20 PST
Created attachment 357130 [details] Patch WIP. Need to split this into smaller patches.
zalan
Comment 2 2018-12-16 18:00:43 PST
Created attachment 357423 [details] Patch WIP
zalan
Comment 3 2018-12-29 08:46:24 PST
Created attachment 358137 [details] Patch
zalan
Comment 4 2018-12-29 09:13:08 PST
Created attachment 358138 [details] Patch
zalan
Comment 5 2018-12-29 18:12:49 PST
Created attachment 358142 [details] Patch
zalan
Comment 6 2018-12-29 18:23:12 PST
Created attachment 358143 [details] Patch
zalan
Comment 7 2018-12-29 20:06:06 PST
Created attachment 358144 [details] Patch
zalan
Comment 8 2019-01-05 21:21:52 PST
Created attachment 358455 [details] Patch
zalan
Comment 9 2019-01-06 21:48:00 PST
Created attachment 358479 [details] Patch
zalan
Comment 10 2019-01-08 07:47:25 PST
Created attachment 358589 [details] Patch
zalan
Comment 11 2019-01-08 21:32:59 PST
Created attachment 358670 [details] Patch
Antti Koivisto
Comment 12 2019-01-09 07:33:05 PST
Comment on attachment 358670 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358670&action=review > Source/WebCore/layout/MarginTypes.h:79 > +struct EstimatedMarginBefore { > + LayoutUnit usedValue; > +}; I suppose this will have more stuff later?
WebKit Commit Bot
Comment 13 2019-01-09 08:08:13 PST
Comment on attachment 358670 [details] Patch Clearing flags on attachment: 358670 Committed r239773: <https://trac.webkit.org/changeset/239773>
WebKit Commit Bot
Comment 14 2019-01-09 08:08:15 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 15 2019-01-09 08:09:30 PST
<rdar://problem/47146753>
Note You need to log in before you can comment on or make changes to this bug.