Bug 192619

Summary: [BigInt] Implement DFG/FTL typeof for BigInt
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, ticaiolima, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch keith_miller: review+

Yusuke Suzuki
Reported 2018-12-12 02:00:02 PST
[BigInt] Implement DFG/FTL typeof for BigInt
Attachments
Patch (9.03 KB, patch)
2018-12-12 02:02 PST, Yusuke Suzuki 		keith_miller: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2018-12-12 02:02:57 PST
Created attachment 357114 [details] Patch
Caio Lima
Comment 2 2018-12-12 05:21:42 PST
Comment on attachment 357114 [details] Patch LGTM, informal r+
Keith Miller
Comment 3 2018-12-12 10:57:13 PST
Comment on attachment 357114 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357114&action=review r=me. > Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:14220 > + // } else if (is bigint) { Do we think that bigints are going to be more or less common than symbol? Also, when we add a value representation for "small big ints" I would expect symbols would be more common. Can we add a FIXME: here to switch the ordering when that happens? > Source/JavaScriptCore/jit/AssemblyHelpers.h:1658 > + // } else if (is bigint) { > + // return bigint Ditto
Yusuke Suzuki
Comment 4 2018-12-12 17:58:19 PST
Comment on attachment 357114 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357114&action=review Thank you! >> Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:14220 >> + // } else if (is bigint) { > > Do we think that bigints are going to be more or less common than symbol? > > Also, when we add a value representation for "small big ints" I would expect symbols would be more common. Can we add a FIXME: here to switch the ordering when that happens? Make sense. Added FIXME here. >> Source/JavaScriptCore/jit/AssemblyHelpers.h:1658 >> + // return bigint > > Ditto Fixed.
Yusuke Suzuki
Comment 5 2018-12-12 18:01:42 PST
Committed r239141: <https://trac.webkit.org/changeset/239141>
Radar WebKit Bug Importer
Comment 6 2018-12-12 18:03:48 PST
<rdar://problem/46683130>
Note You need to log in before you can comment on or make changes to this bug.