Bug 192591

Summary: Don't attempt to compute animated values when there is no relevant animation
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: SVGAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, dino, sabouhallawa, zalan, zimmermann
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Brent Fulgham
Reported 2018-12-11 09:03:36 PST
We see nullptr errors in SVGAnimateElementBase::calculateAnimatedValue because it attempts to calculate the animation value of a property that is not being animated. WebKit does the right thing when setting the animation type, but when animation values are requested, we ignore the fact that the property is either (a) not supposed to be animated, or (b) has no animated properties, and attempt to use the nullptr value to check the result. We should bail out early if an animation value is requested for a property that is not being animated.
Attachments
Patch (2.38 KB, patch)
2018-12-11 09:07 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (6.25 KB, patch)
2018-12-11 13:26 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2018-12-11 09:04:59 PST
<rdar://problem/34336946>
Brent Fulgham
Comment 2 2018-12-11 09:07:01 PST
Created attachment 357052 [details] Patch
Brent Fulgham
Comment 3 2018-12-11 13:26:25 PST
Created attachment 357072 [details] Patch
WebKit Commit Bot
Comment 4 2018-12-11 14:34:48 PST
Comment on attachment 357072 [details] Patch Clearing flags on attachment: 357072 Committed r239090: <https://trac.webkit.org/changeset/239090>
WebKit Commit Bot
Comment 5 2018-12-11 14:34:49 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.