Bug 192591

Summary: Don't attempt to compute animated values when there is no relevant animation
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: SVGAssignee: Brent Fulgham <bfulgham>
Severity: Normal CC: bfulgham, commit-queue, dino, sabouhallawa, zalan, zimmermann
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch none

Description Brent Fulgham 2018-12-11 09:03:36 PST
We see nullptr errors in SVGAnimateElementBase::calculateAnimatedValue because it attempts to calculate the animation value of a property that is not being animated.

WebKit does the right thing when setting the animation type, but when animation values are requested, we ignore the fact that the property is either (a) not supposed to be animated, or (b) has no animated properties, and attempt to use the nullptr value to check the result.

We should bail out early if an animation value is requested for a property that is not being animated.
Comment 1 Brent Fulgham 2018-12-11 09:04:59 PST
Comment 2 Brent Fulgham 2018-12-11 09:07:01 PST
Created attachment 357052 [details]
Comment 3 Brent Fulgham 2018-12-11 13:26:25 PST
Created attachment 357072 [details]
Comment 4 WebKit Commit Bot 2018-12-11 14:34:48 PST
Comment on attachment 357072 [details]

Clearing flags on attachment: 357072

Committed r239090: <https://trac.webkit.org/changeset/239090>
Comment 5 WebKit Commit Bot 2018-12-11 14:34:49 PST
All reviewed patches have been landed.  Closing bug.