Bug 192589

Summary: [FreeType] Remove HarfBuzzFace
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: TextAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, mcatanzaro, mmaxfield, webkit-bug-importer
Priority: P2 Keywords: Gtk, InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 192151    
Bug Blocks:    
Attachments:
Description Flags
Patch
mcatanzaro: review+
Patch for landing none

Carlos Garcia Campos
Reported 2018-12-11 06:50:13 PST
This was used to share the common implementation with the chromium port, but now that only freetype based ports use it, it can be removed and use hb_ft_face_create_cached() instead. We don't need the glyph cache either, since we are already caching glyphs in Font.
Attachments
Patch (45.12 KB, patch)
2018-12-11 06:58 PST, Carlos Garcia Campos 		mcatanzaro: review+
DetailsFormatted DiffDiff
Patch for landing (45.08 KB, patch)
2018-12-13 01:20 PST, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2018-12-11 06:58:04 PST
Created attachment 357047 [details] Patch
Carlos Garcia Campos
Comment 2 2018-12-11 06:58:28 PST
I wrote this patch on top of patch attached to bug #192151
Michael Catanzaro
Comment 3 2018-12-11 14:58:35 PST
Comment on attachment 357047 [details] Patch Probably goes without saying, but you should see if Myles has comments before landing this.
Carlos Garcia Campos
Comment 4 2018-12-12 01:19:56 PST
Committed r239101: <https://trac.webkit.org/changeset/239101>
Radar WebKit Bug Importer
Comment 5 2018-12-12 01:21:27 PST
<rdar://problem/46655797>
Michael Catanzaro
Comment 6 2018-12-12 11:05:37 PST
Reopening. I rolled this out in r239122 because it depends on bug #192151.
Carlos Garcia Campos
Comment 7 2018-12-13 01:20:36 PST
Created attachment 357219 [details] Patch for landing
Carlos Garcia Campos
Comment 8 2018-12-13 01:43:54 PST
Committed r239157: <https://trac.webkit.org/changeset/239157>
Note You need to log in before you can comment on or make changes to this bug.