Summary: | [Win][Clang] Fix compilation warnings of WTF | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Fujii Hironori <Hironori.Fujii> | ||||||
Component: | Web Template Framework | Assignee: | Fujii Hironori <Hironori.Fujii> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | achristensen, benjamin, bfulgham, cdumez, cmarcelo, dbates, ews-watchlist, pvollan, ross.kirsling, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 171618 | ||||||||
Attachments: |
|
Created attachment 357041 [details]
Patch
Comment on attachment 357041 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357041&action=review > Source/WTF/wtf/StackBounds.cpp:163 > - MEMORY_BASIC_INFORMATION stackOrigin = { 0 }; > + MEMORY_BASIC_INFORMATION stackOrigin = { }; We should probably remove the = here. (I guess if the default constructor works then we don't necessarily need the { } either, but it doesn't hurt to keep it.) > Source/WTF/wtf/win/RunLoopWin.cpp:86 > - WNDCLASS windowClass = { 0 }; > + WNDCLASS windowClass = { }; Ditto. Comment on attachment 357041 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357041&action=review >> Source/WTF/wtf/StackBounds.cpp:163 >> + MEMORY_BASIC_INFORMATION stackOrigin = { }; > > We should probably remove the = here. > (I guess if the default constructor works then we don't necessarily need the { } either, but it doesn't hurt to keep it.) Good catch. Thanks. Will fix. Unfortunately, Windows API is implemented in C. It doesn't have ctor. https://docs.microsoft.com/en-us/windows/desktop/api/winnt/ns-winnt-_memory_basic_information Created attachment 357090 [details]
Patch for landing
Committed r239093: <https://trac.webkit.org/changeset/239093> |
[Win][Clang] Fix compilation warnings of WTF clang-cl reports the following warnings. > [92/206] Building CXX object Source\WTF\wtf\CMakeFiles\WTF.dir\StackBounds.cpp.obj > ..\..\Source\WTF\wtf\StackBounds.cpp(163,48): warning: missing field 'AllocationBase' initializer [-Wmissing-field-initializers] > MEMORY_BASIC_INFORMATION stackOrigin = { 0 }; > ^ > 1 warning generated. > [160/206] Building CXX object Source\WTF\wtf\CMakeFiles\WTF.dir\win\RunLoopWin.cpp.obj > ..\..\Source\WTF\wtf\win\RunLoopWin.cpp(34,54): warning: ISO C++11 does not allow conversion from string literal to 'const LPWSTR' (aka 'wchar_t *const') [-Wwritable-strings] > static const LPWSTR kRunLoopMessageWindowClassName = L"RunLoopMessageWindow"; > ^ > ..\..\Source\WTF\wtf\win\RunLoopWin.cpp(86,32): warning: missing field 'lpfnWndProc' initializer [-Wmissing-field-initializers] > WNDCLASS windowClass = { 0 }; > ^ > 2 warnings generated. > [175/206] Building CXX object Source\WTF\wtf\CMakeFiles\WTF.dir\DateMath.cpp.obj > ..\..\Source\WTF\wtf\DateMath.cpp(125,20): warning: unused function 'getLocalTime' [-Wunused-function] > static inline void getLocalTime(const time_t* localTime, struct tm* localTM) > ^ > 1 warning generated. > [180/206] Building CXX object Source\WTF\wtf\CMakeFiles\WTF.dir\Assertions.cpp.obj > ..\..\Source\WTF\wtf\Assertions.cpp(263,1): warning: function declared 'noreturn' should not return [-Winvalid-noreturn] > } > ^ > 1 warning generated.