Bug 192573

Summary: Move ENABLE_RESOURCE_LOAD_STATISTICS to FeatureDefines.xcconfig
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, benjamin, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, keith_miller, koivisto, mark.lam, mcatanzaro, msaboff, saam, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Don Olmstead
Reported 2018-12-10 16:05:48 PST
Currently ENABLE_RESOURCE_LOAD_STATISTICS is defined in Platform.h. This doesn't seem right. Related discussion on mailing list https://lists.webkit.org/pipermail/webkit-dev/2018-December/030302.html
Attachments
Patch (44.72 KB, patch)
2018-12-10 16:08 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2018-12-10 16:08:47 PST
Created attachment 357012 [details] Patch Testing XCode build.
Michael Catanzaro
Comment 2 2018-12-10 16:10:21 PST
Comment on attachment 357012 [details] Patch Makes sense to get ENABLE_ cruft out of Platform.h. Let's see if EWS is happy with it.
Don Olmstead
Comment 3 2018-12-10 17:28:29 PST
(In reply to Michael Catanzaro from comment #2) > Comment on attachment 357012 [details] > Patch > > Makes sense to get ENABLE_ cruft out of Platform.h. Let's see if EWS is > happy with it. EWS seems to be happy with this change. Would be nice to just get a confirmation from someone on the Apple side just in case.
WebKit Commit Bot
Comment 4 2018-12-10 20:04:53 PST
Comment on attachment 357012 [details] Patch Clearing flags on attachment: 357012 Committed r239068: <https://trac.webkit.org/changeset/239068>
WebKit Commit Bot
Comment 5 2018-12-10 20:04:55 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-12-10 20:05:26 PST
<rdar://problem/46617432>
Note You need to log in before you can comment on or make changes to this bug.