Bug 192565

Summary: Sync FeatureList.pm
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: Tools / TestsAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, commit-queue, dbates, ews-watchlist, lforschler, mcatanzaro, ross.kirsling, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Don Olmstead
Reported 2018-12-10 12:47:29 PST
Follow up with https://bugs.webkit.org/show_bug.cgi?id=191167 to do the same with FeatureList.pm
Attachments
Patch (21.28 KB, patch)
2018-12-10 12:49 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2018-12-10 12:49:31 PST
Created attachment 356985 [details] Patch
Ross Kirsling
Comment 2 2018-12-10 13:41:59 PST
Comment on attachment 356985 [details] Patch Comparing to WebKitFeatures.cmake, it looks like you're missing three: ENABLE_API_TESTS ENABLE_C_LOOP ENABLE_MINIBROWSER Is this intentional?
Don Olmstead
Comment 3 2018-12-10 13:49:38 PST
(In reply to Ross Kirsling from comment #2) > Comment on attachment 356985 [details] > Patch > > Comparing to WebKitFeatures.cmake, it looks like you're missing three: > > ENABLE_API_TESTS > ENABLE_C_LOOP > ENABLE_MINIBROWSER > > Is this intentional? Yes. ENABLE_C_LOOP is really dependent on the target hardware. Minibrowser is dependent on the port. Maybe API tests should be an option but I feel it would be better covered by a specific flag.
WebKit Commit Bot
Comment 4 2018-12-10 16:08:17 PST
Comment on attachment 356985 [details] Patch Clearing flags on attachment: 356985 Committed r239058: <https://trac.webkit.org/changeset/239058>
WebKit Commit Bot
Comment 5 2018-12-10 16:08:19 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-12-10 16:09:27 PST
<rdar://problem/46612077>
Note You need to log in before you can comment on or make changes to this bug.