| Summary: | Sync FeatureList.pm | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Don Olmstead <don.olmstead> | ||||
| Component: | Tools / Tests | Assignee: | Don Olmstead <don.olmstead> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | achristensen, annulen, commit-queue, dbates, ews-watchlist, lforschler, mcatanzaro, ross.kirsling, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Don Olmstead
2018-12-10 12:47:29 PST
Created attachment 356985 [details]
Patch
Comment on attachment 356985 [details]
Patch
Comparing to WebKitFeatures.cmake, it looks like you're missing three:
ENABLE_API_TESTS
ENABLE_C_LOOP
ENABLE_MINIBROWSER
Is this intentional?
(In reply to Ross Kirsling from comment #2) > Comment on attachment 356985 [details] > Patch > > Comparing to WebKitFeatures.cmake, it looks like you're missing three: > > ENABLE_API_TESTS > ENABLE_C_LOOP > ENABLE_MINIBROWSER > > Is this intentional? Yes. ENABLE_C_LOOP is really dependent on the target hardware. Minibrowser is dependent on the port. Maybe API tests should be an option but I feel it would be better covered by a specific flag. Comment on attachment 356985 [details] Patch Clearing flags on attachment: 356985 Committed r239058: <https://trac.webkit.org/changeset/239058> All reviewed patches have been landed. Closing bug. |