Bug 192561
| Summary: | Merge wtf/EventLoop and WebCore EventLoop, and rename it | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> |
| Component: | Web Inspector | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | don.olmstead, hi, inspector-bugzilla-changes, joepeck, simon.fraser, timothy |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Simon Fraser (smfr)
We have EventLoop in both JSC and WebCore. Almost everything seems to use the JSC one, but PageScriptDebugServer::runEventLoopWhilePausedInternal() uses WebCore::EventLoop.
The name “EventLoop” is in demand for HTML5 Event Loop stuff, so I’d like to free up this name if possible. I also think we should rename JSC::EventLoop to something more inspector-specific, since it isn’t a full EventLoop implementation. Can we even move its functionality into the RunLoop class?
Joe says:
> Sure we could easily rename these to be DebuggerRunLoop to free up the name.
> It could probably also move to the RunLoop class. There are some differences between the JSC one and the WebCore one which I believe are still important. But maybe one of the implementations can move down into WTF.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |