Bug 192521

Summary: Animated scrolling on Google Maps scrolls the page in addition to moving the map
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, sam, simon.fraser, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Tim Horton
Reported 2018-12-07 15:45:41 PST
Animated scrolling on Google Maps scrolls the page in addition to moving the map
Attachments
Patch (2.64 KB, patch)
2018-12-07 15:45 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2018-12-07 15:45:48 PST
Created attachment 356846 [details] Patch
Tim Horton
Comment 2 2018-12-07 15:45:49 PST
<rdar://problem/46382007>
Sam Weinig
Comment 3 2018-12-07 20:20:49 PST
Comment on attachment 356846 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=356846&action=review > Source/WebKit/ChangeLog:14 > + * UIProcess/ios/WKKeyboardScrollingAnimator.mm: > + (-[WKKeyboardScrollViewAnimator rubberbandableDirections]): > + Only do keyboard-based rubber-banding in directions that we can actually > + scroll, not directions we can only finger-rubber-band in. This effectively > + means keyboard scrolling will ignore "alwaysBounce{Vertical, Horizontal}". Is there any way to test this?
Tim Horton
Comment 4 2018-12-10 16:23:09 PST
This is one of those things where it's a bit tricky to make a layout test to prove the non-existence of something (e.g. a scroll event) without being slow or flaky. Maybe possible to API test instead.
WebKit Commit Bot
Comment 5 2018-12-10 16:32:46 PST
Comment on attachment 356846 [details] Patch Clearing flags on attachment: 356846 Committed r239059: <https://trac.webkit.org/changeset/239059>
WebKit Commit Bot
Comment 6 2018-12-10 16:32:48 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.