| Summary: | Animated scrolling on Google Maps scrolls the page in addition to moving the map | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||
| Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, sam, simon.fraser, webkit-bug-importer, wenson_hsieh | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Tim Horton
2018-12-07 15:45:41 PST
Created attachment 356846 [details]
Patch
Comment on attachment 356846 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=356846&action=review > Source/WebKit/ChangeLog:14 > + * UIProcess/ios/WKKeyboardScrollingAnimator.mm: > + (-[WKKeyboardScrollViewAnimator rubberbandableDirections]): > + Only do keyboard-based rubber-banding in directions that we can actually > + scroll, not directions we can only finger-rubber-band in. This effectively > + means keyboard scrolling will ignore "alwaysBounce{Vertical, Horizontal}". Is there any way to test this? This is one of those things where it's a bit tricky to make a layout test to prove the non-existence of something (e.g. a scroll event) without being slow or flaky. Maybe possible to API test instead. Comment on attachment 356846 [details] Patch Clearing flags on attachment: 356846 Committed r239059: <https://trac.webkit.org/changeset/239059> All reviewed patches have been landed. Closing bug. |