Bug 192508

Summary: [iOS] Make WebGPU work with remote layer hosting
Product: WebKit Reporter: Dean Jackson <dino>
Component: New BugsAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, graouts, kondapallykalyan, simon.fraser, thorton, tsavell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
thorton: review+
Patch none

Dean Jackson
Reported 2018-12-07 11:49:00 PST
[iOS] Make WebGPU work with remote layer hosting
Attachments
Patch (14.95 KB, patch)
2018-12-07 11:59 PST, Dean Jackson 		thorton: review+
DetailsFormatted DiffDiff
Patch (15.25 KB, patch)
2018-12-07 12:13 PST, Dean Jackson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-12-07 11:49:46 PST
<rdar://problem/46560649>
Dean Jackson
Comment 2 2018-12-07 11:59:28 PST
Created attachment 356827 [details] Patch
Tim Horton
Comment 3 2018-12-07 12:03:35 PST
Comment on attachment 356827 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=356827&action=review > Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:41 > +#if ENABLE(WEBGPU) In its own paragraph! > Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:46 > #if ENABLE(WEBMETAL) Ditto > Source/WebCore/platform/graphics/cocoa/WebGPULayer.h:38 > + float _devicePixelRatio; Native-y code doesn't usually use the webby "devicePixelRatio" but usually "deviceScaleFactor" > Source/WebCore/platform/graphics/cocoa/WebGPULayer.h:43 > +- (id)init; Why?
Dean Jackson
Comment 4 2018-12-07 12:13:12 PST
Created attachment 356828 [details] Patch
Dean Jackson
Comment 5 2018-12-07 13:10:44 PST
Committed r238965: <https://trac.webkit.org/changeset/238965>
Truitt Savell
Comment 6 2018-12-10 09:17:31 PST
Reverted r238965 for reason: Caused internal iOS build failures Committed r239031: <https://trac.webkit.org/changeset/239031>
Dean Jackson
Comment 7 2018-12-10 11:38:03 PST
Committed r239036: <https://trac.webkit.org/changeset/239036>
Note You need to log in before you can comment on or make changes to this bug.