Bug 192497

Summary: Fix build on 64bit ARM with arm64 SYSTEM_PROCESSOR
Product: WebKit Reporter: Lucas Stach <l.stach>
Component: CMakeAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, don.olmstead, ews-watchlist, l.stach, pnormand
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Suggested patch to fix ARM64 build
none
Patch
none
Patch
none
Archive of layout-test-results from ews123 for ios-simulator-wk2 none

Lucas Stach
Reported 2018-12-07 04:53:48 PST
Created attachment 356802 [details] Suggested patch to fix ARM64 build Android and some embedded Linux build systems use arm64 instead of aarch64 as the CMAKE_HOST_PROCESSOR. This patch fixes the JIT build in this scenario.
Attachments
Suggested patch to fix ARM64 build (1.00 KB, patch)
2018-12-07 04:53 PST, Lucas Stach 		no flags
DetailsFormatted DiffDiff
Patch (1.45 KB, patch)
2018-12-07 05:22 PST, Lucas Stach 		no flags
DetailsFormatted DiffDiff
Patch (1.35 KB, patch)
2018-12-18 11:56 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews123 for ios-simulator-wk2 (2.52 MB, application/zip)
2018-12-18 13:45 PST, EWS Watchlist 		no flags
Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2018-12-07 05:03:26 PST
Thanks for the patch! (Unfortunately) a ChangeLog is required though, the contributor workflow is quite well explained in https://webkit.org/contributing-code/
Lucas Stach
Comment 2 2018-12-07 05:22:59 PST
Created attachment 356805 [details] Patch
EWS Watchlist
Comment 3 2018-12-07 05:25:02 PST
Attachment 356805 [details] did not pass style-queue: ERROR: ChangeLog:4: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Philippe Normand
Comment 4 2018-12-07 05:28:43 PST
Comment on attachment 356805 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=356805&action=review > ChangeLog:6 > + Android and some embedded Linux build systems use arm64 instead of > + aarch64 as the CMAKE_HOST_PROCESSOR. Fix JIT build for this scenario. > + > + https://bugs.webkit.org/show_bug.cgi?id=192497 Usually the format is: """ bug title as in Bugzilla Bugzilla link Explanation of the changes """
Don Olmstead
Comment 5 2018-12-18 11:56:49 PST
Created attachment 357593 [details] Patch Hi Lucas, I'm attaching a Changelog that will pass the style checker. As Phillipe mentioned the workflow is explained https://webkit.org/contributing-code for future reference.
EWS Watchlist
Comment 6 2018-12-18 13:45:03 PST
Comment on attachment 357593 [details] Patch Attachment 357593 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10462296 New failing tests: imported/w3c/web-platform-tests/service-workers/service-worker/register-closed-window.https.html
EWS Watchlist
Comment 7 2018-12-18 13:45:05 PST
Created attachment 357607 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Philippe Normand
Comment 8 2018-12-19 00:42:39 PST
Comment on attachment 357593 [details] Patch Thanks Dom!
WebKit Commit Bot
Comment 9 2018-12-19 07:37:58 PST
Comment on attachment 357593 [details] Patch Clearing flags on attachment: 357593 Committed r239378: <https://trac.webkit.org/changeset/239378>
WebKit Commit Bot
Comment 10 2018-12-19 07:37:59 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.