| Summary: | Add keychain access entitlement to WebKitTestRunnerApp | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jiewen Tan <jiewen_tan> | ||||
| Component: | Tools / Tests | Assignee: | Jiewen Tan <jiewen_tan> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ap, bfulgham, commit-queue, jiewen_tan, lforschler | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Jiewen Tan
2018-12-06 22:46:08 PST
Created attachment 356784 [details]
Patch
Comment on attachment 356784 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=356784&action=review > Tools/ChangeLog:3 > + Add keychain access entitlement to WebKitTestRunnerApp Does this fix tests? Comment on attachment 356784 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=356784&action=review >> Tools/ChangeLog:3 >> + Add keychain access entitlement to WebKitTestRunnerApp > > Does this fix tests? Yes, it does. The error is about WebKitTestRunnerApp don't have the entitlement to query Keychain. iOS simulator always has some weird settings other than real devices. Are there any tests that should be unskipped with this change? (In reply to Alexey Proskuryakov from comment #5) > Are there any tests that should be unskipped with this change? Those expectations are within internal. Comment on attachment 356784 [details]
Patch
Thanks Alexey for r+ this patch.
Comment on attachment 356784 [details] Patch Clearing flags on attachment: 356784 Committed r238970: <https://trac.webkit.org/changeset/238970> All reviewed patches have been landed. Closing bug. |